Review main Merged

74524[TASK] Replace deprecated doctrine/dbal 'getSchemaManager()'

Stefan Bürk CR +2 V +2 Easy +7 −9 updated 05/06/22, 13:18

Commit message

'doctrine/dbal' 3.x deprecated the 'getSchemaManager()'
method in favour of the 'createSchemaManager()' method
on connections. This has been aligned in core with the
doctrine/dbal raise in #96287. However, two occurances
with corresponding todo comments has been overseen.

This patch replace the calls and solves the comments of
the left-overs. Additionally, unrelated wrapper method in
ext:install database checks has aligned to the same name
to avoid confusion when looking for the deprecated method.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Stefan Bürk uploaded patch set 1 05/04/22, 22:20

  2. Stefan Bürk updated the commit message in patch set 2 05/04/22, 22:24

  3. core-ci voted on patch set 1 V +1 05/04/22, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26853

  4. core-ci voted on patch set 2 V +1 05/04/22, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26855

  5. Stefan Bürk commented on patch set 2 05/04/22, 22:55

  6. core-ci commented on patch set 2 05/04/22, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26858

  7. Benni Mack voted on patch set 2 CR +1 05/05/22, 07:02

  8. Oliver Klee voted on patch set 2 CR +1 05/05/22, 07:37

  9. Benni Mack voted on patch set 2 V +1 05/05/22, 12:56

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 05/06/22, 13:01

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 05/06/22, 13:18

  12. Stefan Bürk merged patch set 3 05/06/22, 13:18