Review main Merged

74526[TASK] Unify log messages in DataHandler to be PSR-3 compliant

Benni Mack CR +2 V +2 Normal +108 −85 updated 05/05/22, 12:13

Commit message

This change adapts DataHandler logs to use
interpolation from PSR-3 instead of %s to identify
variables in log_details properly later-on.

This makes all log messages from DataHandler and Workspaces
PSR-3 compliant.

In addition, all messages do not contain a "!" at the end anymore,
as there is no need to emphasize errors through the log message
itself (that's why there is type "Error" for logging).
Same goes for "." in order to be consistent.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 711

  1. Benni Mack uploaded patch set 1 05/05/22, 08:27

  2. core-ci voted on patch set 1 V -1 05/05/22, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26874

  3. Benni Mack uploaded patch set 2 05/05/22, 09:10

  4. core-ci voted on patch set 2 V -1 05/05/22, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26875

  5. Benni Mack uploaded patch set 3 05/05/22, 10:12

  6. core-ci voted on patch set 3 V -1 05/05/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26877

  7. core-ci voted on patch set 3 V +1 05/05/22, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26877

  8. Jochen Roth voted on patch set 3 V +1 CR +1 05/05/22, 11:05

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 05/05/22, 11:06

  10. Georg Ringer voted on patch set 3 V +2 CR +2 05/05/22, 12:13

  11. Georg Ringer merged patch set 4 05/05/22, 12:13