Review main Merged

74527[TASK] Use PSR-3 compliant logging in ExtendedFileUtility

Benni Mack CR +2 V +2 Normal +107 −107 updated 05/06/22, 12:53

Commit message

This change adapts ExtendedFileUtility logs to use
interpolation from PSR-3 instead of %s to identify
variables in log_details properly later-on.

This makes all log messages from ExtendedFileUtility
PSR-3 compliant.

In addition, details_nr is not in use anymore since TYPO3 v6,
so the arbitrary ID is removed when logging.

Also, all messages do not contain a "!" at the end anymore,
as there is no need to emphasize errors through the log message
itself (that's why there is type "Error" for logging).
Same goes for "." in order to be consistent.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Benni Mack uploaded patch set 1 05/05/22, 10:11

  2. core-ci voted on patch set 1 V -1 05/05/22, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26876

  3. Benni Mack uploaded patch set 2 05/05/22, 10:36

  4. core-ci voted on patch set 2 V +1 05/05/22, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26879

  5. Oliver Hader commented on patch set 2 CR +1 05/05/22, 13:00

    Good one! As it shows, that log messages (not localized) and notifications (localizable) are different things/scopes.
  6. Jochen Roth commented on patch set 2 05/05/22, 13:19

    ExtendedFileUtility.php:1075

    IMO, it would make sense to add the storage name to the destination, this would prevent empty destination in log messsages when uploading a file to the storage root (e.g. fileadmin/): > Uploading file "Bildschirmfoto 2022-02-04 um 15.34.56.png" to "" ``` $targetFolderObject->getStorage()->getName() . '/' . $targetFolderObject->getIdentifier() ```
  7. Benni Mack commented on patch set 2 05/05/22, 14:27

    ExtendedFileUtility.php:1075 Reply

    I think we should tackle this one separately (there are a lot of problems in this class :))
  8. Jochen Roth voted on patch set 2 V +1 CR +1 05/05/22, 14:28

  9. Nikita Hovratov uploaded patch set 3 05/06/22, 10:28

  10. core-ci voted on patch set 3 V -1 05/06/22, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26900

  11. core-ci voted on patch set 3 V +1 05/06/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26900

  12. Nikita Hovratov voted on patch set 3 V +1 CR +1 05/06/22, 12:14

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 05/06/22, 12:53

  14. Christian Kuhn merged patch set 4 05/06/22, 12:53