74527[TASK] Use PSR-3 compliant logging in ExtendedFileUtility
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1014
-
Benni Mack uploaded patch set 1 05/05/22, 10:11
-
core-ci voted on patch set 1 V -1 05/05/22, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26876
-
Benni Mack uploaded patch set 2 05/05/22, 10:36
-
core-ci voted on patch set 2 V +1 05/05/22, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26879
-
Oliver Hader commented on patch set 2 CR +1 05/05/22, 13:00
Good one! As it shows, that log messages (not localized) and notifications (localizable) are different things/scopes. -
Jochen Roth commented on patch set 2 05/05/22, 13:19
ExtendedFileUtility.php:1075IMO, it would make sense to add the storage name to the destination, this would prevent empty destination in log messsages when uploading a file to the storage root (e.g. fileadmin/): > Uploading file "Bildschirmfoto 2022-02-04 um 15.34.56.png" to "" ``` $targetFolderObject->getStorage()->getName() . '/' . $targetFolderObject->getIdentifier() ``` -
Benni Mack commented on patch set 2 05/05/22, 14:27
ExtendedFileUtility.php:1075ReplyI think we should tackle this one separately (there are a lot of problems in this class :)) -
Jochen Roth voted on patch set 2 V +1 CR +1 05/05/22, 14:28
-
Nikita Hovratov uploaded patch set 3 05/06/22, 10:28
-
core-ci voted on patch set 3 V -1 05/06/22, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26900
-
core-ci voted on patch set 3 V +1 05/06/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26900
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 05/06/22, 12:14
-
Christian Kuhn voted on patch set 3 V +2 CR +2 05/06/22, 12:53
-
Christian Kuhn merged patch set 4 05/06/22, 12:53