Review main Merged

74529[BUGFIX] Avoid postgresql error previewing a fe_group-protected page

Stephan Großberndt CR +2 V +2 Easy +3 −1 updated 05/07/22, 12:45

Commit message

Avoid a postgresql error when previewing a page from the backend which
has an access protection by a fe_group due to PreviewSimulator faking
a fe_user with uid PHP_INT_MAX and sql failure to update the is_online
status of this fake user in PostgreSQL as column fe_users.uid is of type
integer and thus has max value of 2147483647 instead of PHP_INT_MAX.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1721

  1. Stephan Großberndt uploaded patch set 1 05/06/22, 08:50

  2. core-ci voted on patch set 1 V +1 05/06/22, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26893

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 05/06/22, 09:38

  4. Stefan Bürk voted on patch set 1 V 0 CR 0 05/06/22, 09:57

  5. Oliver Klee commented on patch set 1 CR -1 05/06/22, 10:08

    FrontendUserAuthentication.php:516

    I think we should have a comment explaining why we're checking for PHP_INT_MAX here. (Only from reading the code, this is not obvious.)
  6. Stefan Bürk commented on patch set 1 CR -1 05/06/22, 10:58

    on it ....

    FrontendUserAuthentication.php:516 Reply

    ack.
  7. Stefan Bürk commented on patch set 1 05/06/22, 11:09

    main
  8. Stefan Bürk uploaded patch set 2 05/06/22, 11:10

  9. Stefan Bürk commented on patch set 2 05/06/22, 11:10

    Reply

    Done

    FrontendUserAuthentication.php:516 Reply

    Done
  10. Oliver Klee voted on patch set 2 CR +1 05/06/22, 11:14

  11. core-ci voted on patch set 2 V -1 05/06/22, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26902

  12. core-ci voted on patch set 2 V +1 05/06/22, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26902

  13. Stephan Großberndt voted on patch set 2 V +1 CR +1 05/06/22, 12:12

  14. Stephan Großberndt commented on patch set 3 05/06/22, 12:13

    Published edit on patch set 2.
  15. core-ci voted on patch set 3 V +1 05/06/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26909

  16. Oliver Klee voted on patch set 3 CR +1 05/06/22, 12:25

  17. Stefan Bürk voted on patch set 3 V +1 CR +1 05/06/22, 13:14

  18. Andreas Kienast voted on patch set 3 CR +1 05/06/22, 13:36

  19. Nikita Hovratov voted on patch set 3 V +1 CR +1 05/07/22, 11:55

  20. Stefan Bürk voted on patch set 3 V +2 CR +2 05/07/22, 12:45

  21. Stefan Bürk merged patch set 4 05/07/22, 12:45