Review main Merged

74530[BUGFIX] Remove "overflow: hidden" from form-wizards-element

Nikita Hovratov CR +2 V +2 Easy +2 −6 updated 05/06/22, 13:01

Commit message

In order to fix select fields overflowing into each other
when they have very long option titles, the CSS rule
"overflow: hidden" has been added. As it seems, this wasn't
even necessary as the rule "min-width: 120px" already does
the trick.

The CSS rule "overflow: hidden" is now removed, which
enables the accessibility box-shadows from bootstrap 5
again.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 610

  1. Nikita Hovratov uploaded patch set 1 05/06/22, 09:21

  2. Nikita Hovratov updated the commit message in patch set 2 05/06/22, 09:23

  3. core-ci voted on patch set 1 V -1 05/06/22, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26895

  4. core-ci voted on patch set 2 V -1 05/06/22, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26896

  5. core-ci commented on patch set 2 05/06/22, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26896

  6. core-ci voted on patch set 2 V +1 05/06/22, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26896

  7. Benjamin Franzke voted on patch set 2 V +1 CR +1 05/06/22, 10:59

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 05/06/22, 12:55

  9. Nikita Hovratov voted on patch set 2 V +2 CR +2 05/06/22, 13:00

  10. Nikita Hovratov merged patch set 3 05/06/22, 13:01