74531[TASK] Replace docker-compose in runTests.sh
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 58110
Show 4685 earlier messages
-
Jochen Roth uploaded patch set 1 05/06/22, 09:26
-
core-ci voted on patch set 1 V -1 05/06/22, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26897
-
Jochen Roth uploaded patch set 2 05/08/22, 22:12
-
core-ci voted on patch set 2 V -1 05/08/22, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27011
-
Jochen Roth uploaded patch set 3 05/09/22, 14:50
-
core-ci voted on patch set 3 V -1 05/09/22, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27036
-
Jochen Roth uploaded patch set 4 05/09/22, 16:07
-
Jochen Roth uploaded patch set 5 05/09/22, 16:08
-
core-ci voted on patch set 4 V -1 05/09/22, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27038
-
core-ci voted on patch set 5 V -1 05/09/22, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27039
-
Benjamin Franzke uploaded patch set 6 05/09/22, 19:08
-
core-ci voted on patch set 6 V -1 05/09/22, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27049
-
Jochen Roth uploaded patch set 7 05/10/22, 14:00
-
core-ci voted on patch set 7 V -1 05/10/22, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27097
-
Jochen Roth uploaded patch set 8 05/11/22, 22:44
-
core-ci voted on patch set 8 V -1 05/11/22, 22:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27126
-
Jochen Roth uploaded patch set 9 05/14/22, 18:48
-
core-ci voted on patch set 9 V -1 05/14/22, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27216
-
Stefan Bürk uploaded patch set 10 05/14/22, 19:49
-
core-ci voted on patch set 10 V -1 05/14/22, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27217
-
Jochen Roth uploaded patch set 11 05/16/22, 07:14
-
core-ci voted on patch set 11 V -1 05/16/22, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27245
-
Jochen Roth uploaded patch set 12 05/16/22, 22:08
-
core-ci voted on patch set 12 V -1 05/16/22, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27267
-
Jochen Roth uploaded patch set 13 05/17/22, 15:00
-
core-ci voted on patch set 13 V -1 05/17/22, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27283
-
Benni Mack updated the commit message in patch set 14
V -105/03/23, 09:17 -
core-ci voted on patch set 14 V -1 05/03/23, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41392
-
Jochen Roth uploaded patch set 15
V -107/04/23, 21:34 -
core-ci voted on patch set 15 V -1 07/04/23, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43445
-
Jochen Roth uploaded patch set 16
V -107/05/23, 13:41 -
core-ci voted on patch set 16 V -1 07/05/23, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43523
-
Jochen Roth uploaded patch set 17
V -107/06/23, 10:28 -
core-ci voted on patch set 17 V -1 07/06/23, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43690
-
Jochen Roth uploaded patch set 18
V -107/06/23, 11:35 -
core-ci voted on patch set 18 V -1 07/06/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43708
-
Susi Moog uploaded patch set 19
V -107/06/23, 18:24 -
core-ci voted on patch set 19 V -1 07/06/23, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43803
-
Susi Moog uploaded patch set 20
V -107/06/23, 18:28 -
core-ci voted on patch set 20 V -1 07/06/23, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43804
-
Susi Moog uploaded patch set 21
V -107/06/23, 21:38 -
core-ci voted on patch set 21 V -1 07/06/23, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43840
-
Jochen Roth uploaded patch set 22
V -107/07/23, 10:05 -
core-ci voted on patch set 22 V -1 07/07/23, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43880
-
Stefan Bürk uploaded patch set 23
V -107/11/23, 15:37 -
core-ci voted on patch set 23 V -1 07/11/23, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44052
-
Stefan Bürk commented on patch set 23 07/11/23, 16:43
Just commenting some test finding, already had a littla talk with Jochen about it: * cglGit / cglHeaderGit => `git safe.directory` issue * functional sqlite not really working, tests red - wrong database ? Something off * unit tests could not find phpunit (fixed and pushed) * acceptanceInstall sqlite test not working * acceptance tests `-c x/y` argument not working: `No tests executed!` * container should get a prefix (identifier) to have some namespacing here (later to be made a little dynamic) * user uid mac -> some backup links why this is not needed on mack with pure docker / hurts with pure docker vs docker-compose - and should at least commented in the script as info Overall already nice work .... -
Stefan Bürk commented on patch set 23 07/12/23, 16:14
Reply
Had a permission issue after switching pack to the docker-compose variant. Needed to use sudo to remove folders. Forgot to note correct folders. Just wanted to add it here to not forget it. -
Christian Kuhn uploaded patch set 24
V -107/19/23, 10:12 -
core-ci voted on patch set 24 V -1 07/19/23, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44301
-
Christian Kuhn uploaded patch set 25
V -107/19/23, 10:41 -
core-ci voted on patch set 25 V -1 07/19/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44306
-
Christian Kuhn uploaded patch set 26
V -107/19/23, 11:23 -
core-ci voted on patch set 26 V -1 07/19/23, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44307
-
Christian Kuhn uploaded patch set 27
V -107/20/23, 12:22 -
core-ci voted on patch set 27 V -1 07/20/23, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44343
-
Christian Kuhn uploaded patch set 28
V -107/20/23, 13:53 -
Christian Kuhn commented on patch set 28 07/20/23, 13:54
Reply
that's because ac tests don't set proper user rights. will fix. -
core-ci voted on patch set 28 V -1 07/20/23, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44347
-
Christian Kuhn uploaded patch set 29
V -107/20/23, 14:12 -
core-ci voted on patch set 29 V +1 07/20/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44349
-
Christian Kuhn uploaded patch set 30
V +107/20/23, 14:31 -
core-ci voted on patch set 30 V +1 07/20/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44351
-
Christian Kuhn uploaded patch set 31
V +107/20/23, 14:46 -
core-ci voted on patch set 31 V +1 07/20/23, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44352
-
Christian Kuhn uploaded patch set 32
V +107/20/23, 15:04 -
Christian Kuhn uploaded patch set 33 07/20/23, 15:08
-
core-ci voted on patch set 32 V +1 07/20/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44353
-
core-ci voted on patch set 33 V +1 07/20/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44354
-
Christian Kuhn uploaded patch set 34
V +107/20/23, 15:15 -
core-ci voted on patch set 34 V +1 07/20/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44355
-
Christian Kuhn uploaded patch set 35
V +107/21/23, 11:06 -
core-ci voted on patch set 35 V +1 07/21/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44375
-
Christian Kuhn uploaded patch set 36
V +107/21/23, 12:36 -
core-ci voted on patch set 36 V +1 07/21/23, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44380
-
Christian Kuhn uploaded patch set 37
V +107/21/23, 13:29 -
Christian Kuhn uploaded patch set 38 07/21/23, 13:32
-
core-ci voted on patch set 37 V +1 07/21/23, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44381
-
core-ci voted on patch set 38 V +1 07/21/23, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44382
-
Christian Kuhn uploaded patch set 39
V +107/21/23, 13:44 -
core-ci voted on patch set 39 V +1 07/21/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44384
-
Christian Kuhn updated the commit message in patch set 40
V +107/21/23, 13:55 -
Christian Kuhn updated the commit message in patch set 41 07/21/23, 13:57
-
Christian Kuhn updated the commit message in patch set 42 07/21/23, 13:58
-
Christian Kuhn updated the commit message in patch set 43 07/21/23, 13:59
-
core-ci voted on patch set 40 V +1 07/21/23, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44387
-
core-ci voted on patch set 41 V +1 07/21/23, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44388
-
core-ci voted on patch set 42 V +1 07/21/23, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44389
-
core-ci voted on patch set 43 V +1 07/21/23, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44390
-
Stefan Bürk commented on patch set 43 V +1 CR +1 07/21/23, 15:56
From my side on a linux machine verified. I guess we should at least wait for some Mac (m1/m2 + intel) and eventually WSL2 tests ..... -
Jochen Roth commented on patch set 43 V +1 CR +1 07/21/23, 22:49
Reply
Tested and works on Mac (M1, Intel) -
Benni Mack updated the commit message in patch set 44
CR +1V +107/21/23, 23:43 -
Benni Mack commented on patch set 44 CR -2 07/21/23, 23:43
blocked for the time being. -
core-ci voted on patch set 44 V +1 07/21/23, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44407
-
core-ci voted on patch set 43 V -1 07/22/23, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44423
-
core-ci voted on patch set 43 V +1 07/22/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44423
-
Stefan Bürk uploaded patch set 45
V +107/24/23, 08:02Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 45 V +1 07/24/23, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44458
-
Benni Mack voted on patch set 45 CR 0 07/25/23, 09:41
-
Christian Kuhn rebased onto patch set 46
V +107/25/23, 12:24 -
core-ci voted on patch set 46 V +1 07/25/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44524
-
Christian Kuhn uploaded patch set 47
V +107/25/23, 12:41 -
core-ci voted on patch set 47 V +1 07/25/23, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44525
-
core-ci voted on patch set 47 V -1 07/25/23, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44528
-
core-ci commented on patch set 47 07/25/23, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44528
-
core-ci voted on patch set 47 V +1 07/25/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44528
-
Christian Kuhn voted on patch set 47 V +1 CR +1 07/25/23, 14:14
-
Stefan Bürk voted on patch set 47 V +1 CR +1 07/25/23, 14:17
-
Christian Kuhn voted on patch set 47 V +2 CR +2 07/25/23, 14:21
-
Christian Kuhn merged patch set 48 07/25/23, 14:21