74534[BUGFIX] Fix typolink parameter stdWrap when using additional info
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 911
-
Felix Nagel uploaded patch set 1 05/06/22, 13:19
-
core-ci voted on patch set 1 V -1 05/06/22, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26915
-
Felix Nagel uploaded patch set 2 05/06/22, 14:00
-
core-ci voted on patch set 2 V +1 05/06/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26918
-
Nikita Hovratov commented on patch set 2 05/06/22, 14:28
Hey, thanks for the patch. Does this patch only apply for TYPO3 v10? -
Felix Nagel commented on patch set 2 05/06/22, 14:38
Reply
Sadly, yes. In the 11.5 branch there have been some slightly changes (so an adoption should be easy) but in main branch the whole typolink functionality has been extracted. Let's see if we can land this one, than I can work on 11.5 and maybe main branch. -
Nikita Hovratov commented on patch set 2 05/06/22, 14:53
Reply
In the core we work the other way around: First make a patch for the current main branch. And then decide if it is worth to backport to older versions. We must first fix this on main. Keep this patch to fix your projects, but I can tell you that it probably won't be backported for v10, as only critical bugfixes come in. -
Felix Nagel commented on patch set 2 05/06/22, 15:29
Reply
This patch has been done for a client which uses 10.4, so I needed to fix it there first. Oh ok. I will talk to my client and see how he wants to handle this. How about TYPO3 11? Will there be bugfixes? Or main branch only? -
Nikita Hovratov commented on patch set 2 05/06/22, 17:11
Reply
v11 is open for all kinds of bugfixes. For your client I suggest to patch it with composer patches, or if you use the legacy installation, you can fork TYPO3. -
Felix Nagel commented on patch set 2 05/09/22, 09:20
Reply Unresolved
Thanks for the response! I've just created a PR for TYPO3 11: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74576 -
Nikita Hovratov abandoned the change 06/10/22, 14:20
Already merged: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74576