Review main Merged

74536[TASK] CI detection in runTests.sh for phpstan

Stefan Bürk CR +2 V +2 Easy +32 −15 updated 05/07/22, 10:08

Commit message

phpstan parallel execution is limited to a maximum
of 5 processes to be a nice neighbor when executed
during core CI runs. This however leads to longer
execution times when executed on local developer
machines with many available CPU's.

This patch introduces two separated phpstan config
file entrypoints, one for local and one for CI. They
are automatically selected in runTests.sh based on
existence of a CI env variable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1524

  1. Stefan Bürk uploaded patch set 1 05/06/22, 16:22

  2. core-ci voted on patch set 1 V +1 05/06/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26925

  3. Stefan Bürk updated the commit message in patch set 2 05/06/22, 20:52

  4. core-ci voted on patch set 2 V -1 05/06/22, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26932

  5. Stefan Bürk uploaded patch set 3 05/06/22, 22:51

  6. Christian Kuhn updated the commit message in patch set 4 05/06/22, 22:56

  7. core-ci voted on patch set 3 V +1 05/06/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26939

  8. Christian Kuhn commented on patch set 5 05/06/22, 23:00

    Published edit on patch set 4.
  9. core-ci voted on patch set 4 V +1 05/06/22, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26940

  10. core-ci voted on patch set 5 V +1 05/06/22, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26941

  11. Christian Kuhn uploaded patch set 6 05/06/22, 23:07

  12. Christian Kuhn uploaded patch set 7 05/06/22, 23:09

  13. core-ci voted on patch set 7 V +1 05/06/22, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26943

  14. Christian Kuhn uploaded patch set 8 05/06/22, 23:22

  15. core-ci voted on patch set 6 V -1 05/06/22, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26942

  16. Christian Kuhn uploaded patch set 9 05/06/22, 23:23

  17. core-ci voted on patch set 8 V +1 05/06/22, 23:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26944

  18. core-ci voted on patch set 9 V +1 05/06/22, 23:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26945

  19. Stefan Bürk voted on patch set 9 V +1 CR +1 05/06/22, 23:35

  20. Christian Kuhn voted on patch set 9 V +1 CR +1 05/06/22, 23:36

  21. Nikita Hovratov commented on patch set 9 V +1 05/07/22, 07:50

    Stopped times on my Windows / WSL 2 machine: Without patch: 4:15min With patch: 3:50min
  22. Oliver Klee commented on patch set 9 V +1 CR +1 05/07/22, 08:29

    On my mucho-core machine, the results are like this: before: 2:33m after: 0:39m I love this change!
  23. Christian Kuhn voted on patch set 9 V +2 CR +2 05/07/22, 10:08

  24. Christian Kuhn merged patch set 10 05/07/22, 10:08