Review main Abandoned

74538[WIP][TASK] Simplify display constants in template module

Georg Ringer CR 0 V 0 Normal +20 −56 updated 07/24/22, 11:07

Commit message

Remove the default setting "Plain substitution" from the select field.
Now, the constants are always shown in green which helps to identify if
it is a constant or defined in setup.

Todos:
- do we really want it?

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 1012

  1. Georg Ringer uploaded patch set 1 05/06/22, 18:40

  2. core-ci voted on patch set 1 V +1 05/06/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26927

  3. Georg Ringer commented on patch set 1 05/06/22, 19:10

    This change is ready for review.
  4. Benni Mack commented on patch set 1 05/11/22, 11:56

    Yes. I think this is a good thing. Also, I'd also go with the checkbox. As for the styling, I would rather use a CSS class and also adapt the label. Well, if we use a checkbox, we could add the label "Substitute Constants"
  5. Georg Ringer uploaded patch set 2 06/02/22, 19:29

  6. core-ci voted on patch set 2 V +1 06/02/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27661

  7. Simon Schaufelberger commented on patch set 2 06/02/22, 22:07

    Just to let you know, if you are unaware but lolli is just rewriting the whole module, making everything new. I just want to make sure this doesn't conflict with his changes.
  8. Benni Mack commented on patch set 2 06/03/22, 07:18

    I think we should continue on this!
  9. Simon Schaufelberger wrote 06/04/22, 00:26

    Removed cc Simon Schaufelberger.
  10. Christian Kuhn commented on patch set 2 06/06/22, 21:34

    done by https://review.typo3.org/c/Packages/TYPO3.CMS/+/74285/ in a different way - the drop-down isn't in there anymore.
  11. Christian Kuhn commented on patch set 2 07/24/22, 11:07

    constant substitution display is streamlined with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75259 i think it is safe to abandon here.
  12. Christian Kuhn abandoned the change 07/24/22, 11:07