74539[TASK] Render flash messages in backend modules again
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/belog/Resources/Private/Templates/BackendLog/List.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/CompareGroups.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Groups.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+1 −0
Review log 1013
-
Georg Ringer uploaded patch set 1 05/06/22, 19:08
-
Georg Ringer commented on patch set 1 05/06/22, 19:08
This change is ready for review. -
core-ci voted on patch set 1 V +1 05/06/22, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26928
-
Nikita Hovratov commented on patch set 1 05/07/22, 12:02
For BackendLog/List.html I can confirm the missing flashmessages. But for BackendUser/* I can't find any flashmessage in the backend. Where did you find those? -
Georg Ringer commented on patch set 1 05/07/22, 15:54
Reply
I copied in BackendUserController line 360 the "$this->addFlashMessage" to the indexaction to fake it ;) -
Nikita Hovratov commented on patch set 1 05/07/22, 16:08
Reply
Hmm, but if there aren't any then, why should we add the ViewHelper? -
Anja Leichsenring updated the commit message in patch set 2 05/08/22, 10:19
-
core-ci voted on patch set 2 V -1 05/08/22, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26993
-
Anja Leichsenring rebased onto patch set 3 05/08/22, 10:56
-
core-ci voted on patch set 3 V +1 05/08/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26995
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 05/08/22, 11:43
-
Nikita Hovratov voted on patch set 3 V +2 CR +2 05/09/22, 10:39
-
Nikita Hovratov merged patch set 4 05/09/22, 10:40