Review main Merged

74539[TASK] Render flash messages in backend modules again

Georg Ringer CR +2 V +2 Easy +7 −0 updated 05/09/22, 10:40

Commit message

During the refactoring of the backend templates with #96745
the rendering of some flash messages has stopped.

This change adds the output of flash messages again.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1013

  1. Georg Ringer uploaded patch set 1 05/06/22, 19:08

  2. Georg Ringer commented on patch set 1 05/06/22, 19:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/06/22, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26928

  4. Nikita Hovratov commented on patch set 1 05/07/22, 12:02

    For BackendLog/List.html I can confirm the missing flashmessages. But for BackendUser/* I can't find any flashmessage in the backend. Where did you find those?
  5. Georg Ringer commented on patch set 1 05/07/22, 15:54

    Reply

    I copied in BackendUserController line 360 the "$this->addFlashMessage" to the indexaction to fake it ;)
  6. Nikita Hovratov commented on patch set 1 05/07/22, 16:08

    Reply

    Hmm, but if there aren't any then, why should we add the ViewHelper?
  7. Anja Leichsenring updated the commit message in patch set 2 05/08/22, 10:19

  8. core-ci voted on patch set 2 V -1 05/08/22, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26993

  9. Anja Leichsenring rebased onto patch set 3 05/08/22, 10:56

  10. core-ci voted on patch set 3 V +1 05/08/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26995

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/08/22, 11:43

  12. Nikita Hovratov voted on patch set 3 V +2 CR +2 05/09/22, 10:39

  13. Nikita Hovratov merged patch set 4 05/09/22, 10:40