Review 11.5 Merged

74544[TASK] CI detection in runTests.sh for phpstan

Christian Kuhn CR +2 V +2 Easy +32 −15 updated 05/07/22, 10:45

Commit message

phpstan parallel execution is limited to a maximum
of 5 processes to be a nice neighbor when executed
during core CI runs. This however leads to longer
execution times when executed on local developer
machines with many available CPU's.

This patch introduces two separated phpstan config
file entrypoints, one for local and one for CI. They
are automatically selected in runTests.sh based on
existence of a CI env variable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Christian Kuhn uploaded patch set 1 05/07/22, 10:12

  2. core-ci voted on patch set 1 V +1 05/07/22, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26952

  3. Oliver Klee voted on patch set 1 CR +1 05/07/22, 10:36

  4. Oliver Klee voted on patch set 1 V +1 05/07/22, 10:40

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 05/07/22, 10:45

  6. Christian Kuhn merged patch set 2 05/07/22, 10:45