74547[TASK] Ignore PHPStan errors in GeneralUtilityTest for contract violations
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1216
-
Oliver Klee uploaded patch set 1 05/07/22, 12:44
-
Oliver Klee rebased onto patch set 2 05/07/22, 12:46
-
core-ci voted on patch set 2 V +1 05/07/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26959
-
core-ci voted on patch set 1 V +1 05/07/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26957
-
Stefan Bürk commented on patch set 2 V +1 CR +1 05/07/22, 14:59
Right usage for the phpstan ignore annotation. Only for tests explicitly testing broken code or violations. -
Oliver Klee commented on patch set 2 05/07/22, 15:04
> Right usage for the phpstan ignore annotation. Only for tests explicitly testing broken code or violations. I really love learning from each other! -
Benjamin Franzke uploaded patch set 3 05/07/22, 15:53
-
core-ci voted on patch set 3 V +1 05/07/22, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26963
-
Oliver Klee voted on patch set 3 CR +1 05/07/22, 16:02
-
Nikita Hovratov updated the commit message in patch set 4 05/07/22, 16:13
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 05/07/22, 16:14
-
core-ci voted on patch set 4 V +1 05/07/22, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26964
-
Oliver Klee voted on patch set 4 V +1 CR +1 05/07/22, 16:26
-
Oliver Klee voted on patch set 4 V 0 CR 0 05/07/22, 16:36
-
Christian Kuhn voted on patch set 4 V +2 CR +2 05/08/22, 08:41
-
Christian Kuhn merged patch set 5 05/08/22, 08:41