Review main Merged

74548[TASK] Deprecate TYPO3\CMS\Core\Utility\ResourceUtility

Nikita Hovratov CR +2 V +2 Normal +57 −1 updated 05/08/22, 10:05

Commit message

The core utility class ResourceUtility is a leftover from
an old FAL implementation. In a refactoring in TYPO3 v7 this
class was replaced with a direct implementation and has not
been used in the core ever since.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1519

  1. Nikita Hovratov uploaded patch set 1 05/07/22, 19:07

  2. core-ci voted on patch set 1 V +1 05/07/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26978

  3. Oliver Klee updated the commit message in patch set 2 05/07/22, 19:19

  4. Oliver Klee commented on patch set 2 05/07/22, 19:21

    ResourceUtility.php:33

    We also should add @deprecated annotations to the two methods to help IDEs mark any usages.

    ResourceUtilityTest.php:1

    Don’t we also need to change the namespace from /Unit/ to /UnitDeprecated/?
  5. Nikita Hovratov commented on patch set 2 05/07/22, 19:22

    ResourceUtility.php:33 Reply

    When the class is deprecated, then all methods will be marked by the IDE. At least Phpstorm does it.

    ResourceUtilityTest.php:1 Reply

    yes we can, but it's not crucial.
  6. Nikita Hovratov uploaded patch set 3 05/07/22, 19:24

  7. Nikita Hovratov commented on patch set 3 05/07/22, 19:24

    ResourceUtilityTest.php:1 Reply

    Done
  8. Nikita Hovratov commented on patch set 3 05/07/22, 19:25

    ResourceUtility.php:33 Reply

    Or to be more precise, the class name is marked.
  9. Oliver Klee voted on patch set 3 V +1 CR +1 05/07/22, 19:28

  10. Oliver Klee commented on patch set 3 05/07/22, 19:28

    ResourceUtility.php:33 Reply

    Ack
  11. core-ci voted on patch set 3 V +1 05/07/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26982

  12. core-ci voted on patch set 2 V +1 05/07/22, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26981

  13. Christian Kuhn commented on patch set 3 CR -1 05/08/22, 08:32

    will do some minor modifications.
  14. Christian Kuhn uploaded patch set 4 05/08/22, 08:36

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 05/08/22, 08:36

  16. core-ci voted on patch set 4 V +1 05/08/22, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26990

  17. Oliver Klee voted on patch set 4 V +1 CR +1 05/08/22, 09:51

  18. Nikita Hovratov voted on patch set 4 V +2 CR +2 05/08/22, 10:04

  19. Nikita Hovratov merged patch set 5 05/08/22, 10:05