74548[TASK] Deprecate TYPO3\CMS\Core\Utility\ResourceUtility
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Utility/ResourceUtility.php4+13 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97576-TYPO3CMSCoreUtilityResourceUtility.rstnew+38 −0
- typo3/sysext/core/Tests/UnitDeprecated/Utility/ResourceUtilityTest.php3renamed+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 1519
-
Nikita Hovratov uploaded patch set 1 05/07/22, 19:07
-
core-ci voted on patch set 1 V +1 05/07/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26978
-
Oliver Klee updated the commit message in patch set 2 05/07/22, 19:19
-
Oliver Klee commented on patch set 2 05/07/22, 19:21
ResourceUtilityTest.php:1Don’t we also need to change the namespace from /Unit/ to /UnitDeprecated/? -
Nikita Hovratov commented on patch set 2 05/07/22, 19:22
ResourceUtility.php:33ReplyWhen the class is deprecated, then all methods will be marked by the IDE. At least Phpstorm does it.ResourceUtilityTest.php:1Replyyes we can, but it's not crucial. -
Nikita Hovratov uploaded patch set 3 05/07/22, 19:24
-
Nikita Hovratov commented on patch set 3 05/07/22, 19:24
ResourceUtilityTest.php:1ReplyDone -
Nikita Hovratov commented on patch set 3 05/07/22, 19:25
ResourceUtility.php:33ReplyOr to be more precise, the class name is marked. -
Oliver Klee voted on patch set 3 V +1 CR +1 05/07/22, 19:28
-
Oliver Klee commented on patch set 3 05/07/22, 19:28
ResourceUtility.php:33ReplyAck -
core-ci voted on patch set 3 V +1 05/07/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26982
-
core-ci voted on patch set 2 V +1 05/07/22, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26981
-
Christian Kuhn commented on patch set 3 CR -1 05/08/22, 08:32
will do some minor modifications. -
Christian Kuhn uploaded patch set 4 05/08/22, 08:36
-
Christian Kuhn voted on patch set 4 V +1 CR +1 05/08/22, 08:36
-
core-ci voted on patch set 4 V +1 05/08/22, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26990
-
Oliver Klee voted on patch set 4 V +1 CR +1 05/08/22, 09:51
-
Nikita Hovratov voted on patch set 4 V +2 CR +2 05/08/22, 10:04
-
Nikita Hovratov merged patch set 5 05/08/22, 10:05
ResourceUtility.php:33