Review 11.5 Merged

74551[TASK] Ignore PHPStan errors in GeneralUtilityTest for contract violations

Christian Kuhn CR +2 V +2 Easy +5 −25 updated 05/08/22, 08:53

Commit message

In tests for `GeneralUtility` that explicitly violate the contract
(and test the correct error handling in those cases), PHPStan errors about
the contract violation are not helpful and rather clutter the
PHPStan baseline.

So these errors are now silenced with an annotation in the corresponding
tests, allowing us to focus on PHPStan errors about actual issues.

Note: We only use this annotation in tests, not in production code,
to avoid silencing errors about actual problems.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 05/08/22, 08:40

  2. core-ci voted on patch set 1 V +1 05/08/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26991

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 05/08/22, 08:53

  4. Christian Kuhn merged patch set 2 05/08/22, 08:53