Review 10.4 Merged

74552[BUGFIX] Avoid postgresql error previewing a fe_group-protected page

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 05/07/22, 13:11

Commit message

Avoid a postgresql error when previewing a page from the backend which
has an access protection by a fe_group due to PreviewSimulator faking
a fe_user with uid PHP_INT_MAX and sql failure to update the is_online
status of this fake user in PostgreSQL as column fe_users.uid is of type
integer and thus has max value of 2147483647 instead of PHP_INT_MAX.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk commented on patch set 1 05/07/22, 12:47

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php
  2. core-ci voted on patch set 1 V -1 05/07/22, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26960

  3. Stefan Bürk uploaded patch set 2 05/07/22, 12:51

  4. core-ci voted on patch set 2 V +1 05/07/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26961

  5. Oliver Klee voted on patch set 2 CR +1 05/07/22, 13:04

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 05/07/22, 13:11

  7. Stefan Bürk merged patch set 3 05/07/22, 13:11