Review 11.5 Merged

74553[TASK] Resolve "right side of && is always true" in PHPStan

Nikita Hovratov CR +2 V +2 Normal +23 −66 updated 05/07/22, 17:29

Commit message

The PHPStan baseline file has several entries for this error.
This patch resolves them by adjusting the code so the
issue is not relevant.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 610

  1. Nikita Hovratov commented on patch set 1 05/07/22, 16:54

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. core-ci voted on patch set 1 V -1 05/07/22, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26968

  3. Nikita Hovratov uploaded patch set 2 05/07/22, 17:12

  4. Nikita Hovratov uploaded patch set 3 05/07/22, 17:13

  5. core-ci voted on patch set 2 V -1 05/07/22, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26969

  6. core-ci voted on patch set 3 V -1 05/07/22, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26970

  7. Nikita Hovratov uploaded patch set 4 05/07/22, 17:21

  8. core-ci voted on patch set 4 V +1 05/07/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26971

  9. Nikita Hovratov commented on patch set 4 V +2 CR +2 05/07/22, 17:29

    This change is ready for review.
  10. Nikita Hovratov merged patch set 5 05/07/22, 17:29