74553[TASK] Resolve "right side of && is always true" in PHPStan
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
-
Verified V +2 Done
- Nikita Hovratov +2
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+0 −40
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BcryptPasswordHash.php+0 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+16 −18
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+2 −2
- typo3/sysext/core/Classes/Mail/MemorySpool.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+1 −1
Review log 610
-
Nikita Hovratov commented on patch set 1 05/07/22, 16:54
Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon -
core-ci voted on patch set 1 V -1 05/07/22, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26968
-
Nikita Hovratov uploaded patch set 2 05/07/22, 17:12
-
Nikita Hovratov uploaded patch set 3 05/07/22, 17:13
-
core-ci voted on patch set 2 V -1 05/07/22, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26969
-
core-ci voted on patch set 3 V -1 05/07/22, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26970
-
Nikita Hovratov uploaded patch set 4 05/07/22, 17:21
-
core-ci voted on patch set 4 V +1 05/07/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26971
-
Nikita Hovratov commented on patch set 4 V +2 CR +2 05/07/22, 17:29
This change is ready for review. -
Nikita Hovratov merged patch set 5 05/07/22, 17:29