Review main Merged

74572[TASK] Mark GeneralUtility as strict

Oliver Klee CR +2 V +2 Easy +2 −0 updated 07/10/22, 19:09

Commit message

This is the first step before we can start adding
native types to the GU methods in multiple separate
changes.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2443

Show 1018 earlier messages
  1. Oliver Klee uploaded patch set 1 05/08/22, 12:22

  2. Oliver Klee marked it work in progress 05/08/22, 12:22

  3. Oliver Klee uploaded patch set 2 05/08/22, 12:39

  4. Oliver Klee uploaded patch set 3 05/08/22, 12:48

  5. core-ci voted on patch set 1 V -1 05/08/22, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26996

  6. core-ci voted on patch set 2 V -1 05/08/22, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26997

  7. core-ci voted on patch set 3 V -1 05/08/22, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26998

  8. Oliver Klee uploaded patch set 4 05/08/22, 13:23

  9. core-ci voted on patch set 4 V -1 05/08/22, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26999

  10. Oliver Klee uploaded patch set 5 05/08/22, 15:05

  11. core-ci voted on patch set 5 V +1 05/08/22, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27000

  12. Oliver Klee uploaded patch set 6 05/09/22, 13:55

  13. core-ci voted on patch set 6 V +1 05/09/22, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27033

  14. Oliver Klee uploaded patch set 7 05/10/22, 11:34

  15. core-ci voted on patch set 7 V -1 05/10/22, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27095

  16. Oliver Klee rebased onto patch set 8 05/29/22, 12:40

  17. core-ci voted on patch set 8 V +1 05/29/22, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27549

  18. Oliver Klee uploaded patch set 9 06/09/22, 09:12

  1. core-ci voted on patch set 9 V -1 06/09/22, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27866

  2. core-ci voted on patch set 9 V +1 06/09/22, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27866

  3. Oliver Klee uploaded patch set 10 06/09/22, 11:46

  4. core-ci voted on patch set 10 V +1 06/09/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27882

  5. Oliver Klee uploaded patch set 11 06/19/22, 09:53

  6. core-ci voted on patch set 11 V +1 06/19/22, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28217

  7. Oliver Klee rebased onto patch set 12 06/20/22, 10:10

  8. core-ci voted on patch set 12 V +1 06/20/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28251

  9. Oliver Klee uploaded patch set 13 07/09/22, 09:55

  10. core-ci voted on patch set 13 V +1 07/09/22, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28799

  11. Oliver Klee uploaded patch set 14 07/09/22, 10:15

  12. core-ci voted on patch set 14 V +1 07/09/22, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28801

  13. Oliver Klee uploaded patch set 15 07/09/22, 10:31

  14. core-ci voted on patch set 15 V -1 07/09/22, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28802

  15. Oliver Klee uploaded patch set 16 07/09/22, 10:44

  16. core-ci voted on patch set 16 V +1 07/09/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28805

  17. Oliver Klee rebased onto patch set 17 07/10/22, 12:02

  18. core-ci voted on patch set 17 V +1 07/10/22, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28853

  19. Oliver Klee uploaded patch set 18 07/10/22, 14:20

  20. Oliver Klee marked it ready for review 07/10/22, 14:21

  21. Oliver Klee commented on patch set 18 07/10/22, 14:23

    We don't seem to mark making classes strict as breaking. As far as adding types to GU, this already was covered in https://review.typo3.org/c/Packages/TYPO3.CMS/+/75077/3/typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst .
  22. core-ci voted on patch set 18 V +1 07/10/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28857

  23. Nikita Hovratov voted on patch set 18 V +1 CR +1 07/10/22, 15:14

  24. Stefan Bürk voted on patch set 18 V +2 CR +2 07/10/22, 19:08

  25. Stefan Bürk merged patch set 19 07/10/22, 19:09