Review main Merged

74573[BUGFIX] Avoid calling string functions with non-strings in GU

Oliver Klee CR +2 V +2 Easy +14 −10 updated 05/09/22, 13:33

Commit message

This helps avoid breakage when GeneralUtility will switch to
strict mode.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Oliver Klee uploaded patch set 1 05/08/22, 15:25

  2. Oliver Klee updated the commit message in patch set 2 05/08/22, 15:25

  3. core-ci voted on patch set 2 V +1 05/08/22, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27002

  4. core-ci voted on patch set 1 V +1 05/08/22, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27001

  5. Nikita Hovratov uploaded patch set 3 05/09/22, 10:30

  6. Nikita Hovratov uploaded patch set 4 05/09/22, 10:34

  7. Nikita Hovratov voted on patch set 4 V +1 CR +1 05/09/22, 10:36

  8. Oliver Klee commented on patch set 4 05/09/22, 10:37

    Thanks for the update, Nikita!
  9. core-ci voted on patch set 3 V +1 05/09/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27021

  10. core-ci voted on patch set 4 V +1 05/09/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27022

  11. Georg Ringer voted on patch set 4 V +2 CR +2 05/09/22, 13:33

  12. Georg Ringer merged patch set 5 05/09/22, 13:33