Review main Abandoned

74575[BUGFIX] Add floating type as valid overlay handling

Henrik Elsner CR 0 V 0 Easy +1 −1 updated 07/11/22, 19:00

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Henrik Elsner uploaded patch set 1 05/09/22, 07:56

  2. core-ci voted on patch set 1 V -1 05/09/22, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27017

  3. Oliver Klee commented on patch set 1 05/09/22, 10:38

    Can we cover this with a regression test?
  4. Henrik Elsner commented on patch set 1 05/09/22, 11:11

    Reply

    Seems like i have to patch the tests in general. Don't know yet how to do a regression test though. Also in general i am not 100% sure if my patch is correct and/or enough and if there are other places this has to be patched. But i thought, that a commit would help out people with understanding and testing
  5. Henrik Elsner commented on patch set 1 V -1 05/10/22, 06:32

    i further tested this on my local setup. it has several side effects that are not bearable
  6. Oliver Klee wrote 06/10/22, 21:43

    Removed cc Oliver Klee.
  7. Benni Mack commented on patch set 1 07/11/22, 17:32

    Hey Henrik, as a reference: OVERLAYS_ON_WITH_FLOATING = "hideNonTranslated" + the records that have l10n_parent=0 so this is actually a wrong behavior then.
  8. Henrik Elsner abandoned the change 07/11/22, 19:00

    This is bigger than expected and wont be fixed with a small mind like mine :D