74586[BUGFIX] Ensure strings are passed to makeDiffDisplay()
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/DefaultLanguageDifferences.php+2 −2
- typo3/sysext/core/Classes/Utility/DiffUtility.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+3 −3
- typo3/sysext/workspaces/Classes/Service/HistoryService.php+2 −2
Review log 1112
-
Oli Bartsch uploaded patch set 1 05/09/22, 21:18
-
core-ci voted on patch set 1 V +1 05/09/22, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27057
-
Oliver Klee voted on patch set 1 V +1 CR +1 05/09/22, 22:07
-
Oliver Klee commented on patch set 1 CR 0 05/09/22, 22:08
As these are bug fixes, please let's also backport this to 11.5. -
Oli Bartsch commented on patch set 1 05/09/22, 22:11
Reply
This only affects main, due to #97373. -
Oliver Klee commented on patch set 1 05/09/22, 22:28
Reply
I know, and I kind of disagree. :-) Adding the native types uncovered that we were passing the wrong types, which did not cause direct bugs, but still was not correct. Would you be okay with backporting so the code in 11.5 then will also be correct? -
Oliver Klee voted on patch set 1 CR +1 05/09/22, 22:33
-
Christian Kuhn commented on patch set 1 CR +1 05/09/22, 22:41
Reply
i'd be fine with having this in main only. -
Stefan Bürk voted on patch set 1 V +1 05/09/22, 22:42
-
Stefan Bürk commented on patch set 1 05/09/22, 22:43
Reply
fine with main only. -
Georg Ringer voted on patch set 1 V +2 CR +2 05/10/22, 04:55
-
Georg Ringer merged patch set 2 05/10/22, 04:55