Review main Merged

74598[BUGFIX] Fix undefined array key in TemplateService

David Gurk CR +2 V +2 Easy +1 −1 updated 05/10/22, 10:22

Commit message

If a TypoScript sub-template is missing, because it is disabled,
it is necessary to check for the existence.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. David Gurk uploaded patch set 1 05/10/22, 09:00

  2. core-ci voted on patch set 1 V +1 05/10/22, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27080

  3. Oliver Klee voted on patch set 1 CR +1 05/10/22, 09:12

  4. Oli Bartsch commented on patch set 1 05/10/22, 09:22

    TemplateService.php:655

    What do you think about just using "is_array($subTemplates[$id] ?? false)" instead of the extra isset()?
  5. Christian Kuhn commented on patch set 1 05/10/22, 09:29

    TemplateService.php:655 Reply

    yeah. will update.
  6. Christian Kuhn uploaded patch set 2 05/10/22, 09:30

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 05/10/22, 09:31

  8. Oliver Klee voted on patch set 2 CR +1 05/10/22, 09:35

  9. core-ci voted on patch set 2 V +1 05/10/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27084

  10. Georg Ringer voted on patch set 2 V +1 CR +1 05/10/22, 09:46

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 05/10/22, 10:22

  12. Oli Bartsch merged patch set 3 05/10/22, 10:22