Review 11.5 Merged

74619[TASK] Address phpstan "Expression on left side of ??" errors

Stefan Bürk CR +2 V +2 Normal +38 −150 updated 05/13/22, 17:26

Commit message

There are several PHPStan Baseline exceptions for misuse of
the ?? operator. Many of them are no longer necessary thanks
to either other code evolution or PHP evolution. This patch
cleans those up.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 57

  1. Stefan Bürk commented on patch set 1 05/13/22, 17:06

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * typo3/sysext/backend/Classes/Controller/LoginController.php * typo3/sysext/backend/Classes/Controller/ResetPasswordController.php
  2. core-ci voted on patch set 1 V -1 05/13/22, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27184

  3. Stefan Bürk uploaded patch set 2 05/13/22, 17:16

  4. Stefan Bürk marked it ready for review 05/13/22, 17:16

  5. core-ci voted on patch set 2 V +1 05/13/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27185

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 05/13/22, 17:25

  7. Stefan Bürk merged patch set 3 05/13/22, 17:26