74619[TASK] Address phpstan "Expression on left side of ??" errors
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 26
- Build/phpstan/phpstan-baseline.neon+0 −110
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+1 −1
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+1 −4
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/BrowseTreeView.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/Grid.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderPropertyManager.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+1 −1
- typo3/sysext/core/Classes/Routing/PageRouter.php+1 −1
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Repository/BulkExtensionRepositoryWriter.php+4 −4
- typo3/sysext/form/Classes/Mvc/Validation/CountValidator.php+2 −2
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php+3 −3
Show 6 more files
- typo3/sysext/form/Classes/Mvc/Validation/EmptyValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+3 −3
- typo3/sysext/form/Classes/Mvc/Validation/MimeTypeValidator.php+3 −3
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −1
- typo3/sysext/redirects/Classes/Hooks/DataHandlerSlugUpdateHook.php+1 −1
- typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php+1 −1
Review log 57
-
Stefan Bürk commented on patch set 1 05/13/22, 17:06
Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * typo3/sysext/backend/Classes/Controller/LoginController.php * typo3/sysext/backend/Classes/Controller/ResetPasswordController.php -
core-ci voted on patch set 1 V -1 05/13/22, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27184
-
Stefan Bürk uploaded patch set 2 05/13/22, 17:16
-
Stefan Bürk marked it ready for review 05/13/22, 17:16
-
core-ci voted on patch set 2 V +1 05/13/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27185
-
Stefan Bürk voted on patch set 2 V +2 CR +2 05/13/22, 17:25
-
Stefan Bürk merged patch set 3 05/13/22, 17:26