Review main Merged

74620[BUGFIX] Fix typolink parameter stdWrap when using additional info

Felix Nagel CR +2 V +2 Easy +34 −1 updated 08/02/22, 10:24

Commit message

When using stdWrap for setting the actual parameter value, all
additional information (like target, class and title) is lost. With
this change the expected behavior (keeping and rendering all
additional information) is restored.

Using stdWrap for parameter is a useful feature for changing the value
depending on page or record properties. Think of changing the detail
page of a news record based on the type of the news.

To ensure functionality there are two new tests. One for testing the
general functionality when using a stdWrap parameter and one to make
sure additional information is processed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1116

  1. Felix Nagel commented on patch set 1 05/16/22, 08:49

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
  2. core-ci voted on patch set 1 V -1 05/16/22, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27251

  3. Benni Mack uploaded patch set 2 05/19/22, 21:38

  4. Benni Mack marked it ready for review 05/19/22, 21:38

  5. Benni Mack voted on patch set 2 V +1 CR +1 05/19/22, 21:38

  6. core-ci voted on patch set 2 V -1 05/19/22, 22:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27328

  7. Benni Mack rebased onto patch set 3 05/20/22, 06:36

  8. core-ci voted on patch set 3 V -1 05/20/22, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27339

  9. Benni Mack commented on patch set 4 05/20/22, 08:37

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V -1 05/20/22, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27344

  11. core-ci voted on patch set 4 V +1 05/20/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27344

  12. Benni Mack voted on patch set 4 V +1 CR +1 05/20/22, 12:27

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 05/20/22, 12:40

  14. Benni Mack voted on patch set 4 V +2 CR +2 05/20/22, 20:26

  15. Benni Mack merged patch set 5 05/20/22, 20:26

  16. Oliver Hader commented on patch set 5 08/02/22, 10:24

    This seems to be a regression, see https://stackoverflow.com/questions/73204967/typoscript-image-file-link-with-target-blank Besides that, I just does not feel correct to have a special handling of `stdWrap` which is not applied to the base `parameter` value (as string).