Review main Merged

74638[TASK] Simplify code in ConjunctionValidator

crell CR +2 V +2 Easy +4 −19 updated 05/25/22, 11:14

Commit message

The code in ConjunctionValidator can be greatly
simplified by taking advantage of the fact that
an empty result object can be merged with a future
one. That eliminates an unnecessary code path as
well as phpstan warnings.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. crell uploaded patch set 1 05/12/22, 22:04

  2. core-ci voted on patch set 1 V +1 05/12/22, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27158

  3. Stefan Bürk updated the commit message in patch set 2 05/12/22, 23:54

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 05/12/22, 23:54

  5. Stefan Bürk updated the commit message in patch set 3 05/12/22, 23:58

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 05/12/22, 23:58

  7. core-ci voted on patch set 2 V +1 05/13/22, 00:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27159

  8. core-ci voted on patch set 3 V +1 05/13/22, 00:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27160

  9. Simon Schaufelberger voted on patch set 3 V +1 CR +1 05/25/22, 01:28

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 05/25/22, 07:55

  11. Oliver Klee voted on patch set 3 CR +1 05/25/22, 10:31

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 05/25/22, 11:13

  13. Christian Kuhn merged patch set 4 05/25/22, 11:14