Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

74641[WIP][FEATURE] Introduce responsive, flexbox based FSC textmedia styling

Benjamin Franzke CR 0 V 0 Normal +122 −58 updated 08/12/22, 04:39

Commit message

* Make use of configurable flexbox grow-ratios and base widths
   to automatically switch from side-by-side view ("desktop")
   to mobie view (two rows) without media queries

 * Drop ce-outer and ce-outer position:relative + float hacks
   for center alignment of galleries

 * Prevent floats wherever possible

 * Streamline margins to work in responsive mode

 * Replace old-school float clearing (`overflow: hidden`)
   by a pseudo selector that defines `clear: both`.
   (this avoids the overflow-hidden sideeffects of possibly
   cropping content)

 * No markup changes for easy updates

TODO:

 * Depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/73527
   these two changes should become an optional/new style,
   the old one needs to be made available for BC

 * Decide on how many css properties should also be
   typoscript constants

 * Test test…

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/74641/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/74641/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 74641 [WIP][FEATURE] Introduce responsive, flexbox based FSC textmedia styling This change

  2. main 73527[POC][!!!][FEATURE] Introduce CSS variables for FSC styling options This change is based on it Abandoned Nikita Hovratov CR 0 V 0 Hard +526 −81

Files 3

Review log 24

  1. Benjamin Franzke uploaded patch set 1 05/13/22, 07:02

  2. core-ci voted on patch set 1 V -1 05/13/22, 07:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27170

  3. Benjamin Franzke uploaded patch set 2 08/12/22, 04:31

  4. core-ci voted on patch set 2 V +1 08/12/22, 04:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30060