Review main Abandoned

74647[TASK] Change handling of PHP versions in runTests.sh

Sybille Peters CR 0 V 0 Normal +55 −32 updated 05/17/22, 06:27

Commit message

Enhance maintainability of PHP version in help texts in runTests.h
by using variables for default PHP version and supported PHP versions.

The already existing variable PHP_VERSION is used and an additional
variable SUPPORTED_PHP_VERSIONS is introduced.

The variables are placed at the top of the script. The help texts
and examples are changed to use the variables, where it makes sense.

Thus, it will only be necessary to change the variables at the top
of the script and leave the rest as it is.

Previously, when supported and default PHP versions changed, the
versions had to be changed in various places in runTest.sh,
sometimes resulting in a mismatch between the comment for an
example and the example itself.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Sybille Peters uploaded patch set 1 05/15/22, 11:48

  2. core-ci voted on patch set 1 V +1 05/15/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27224

  3. Oliver Klee voted on patch set 1 CR +1 05/15/22, 12:06

  4. Stefan Bürk uploaded patch set 2 05/16/22, 16:40

  5. Stefan Bürk commented on patch set 2 05/16/22, 16:45

    Unresolved

    Changed that the output of the php version at least follows the known format. However - not convinced of this changes. Do not see the benefit of it to have it "dynamic" at all. And "stating" a PHP version "not available" at all as example feels kinda weired. There is no "PHP 8.2" yet. So for that alone, I would not take this patch in. We can change the example "to 8.2" if it exists. Would not remove the different example, and keep them to simple raise as soon as we have a "PHP 8.2" support for main.
  6. core-ci voted on patch set 2 V +1 05/16/22, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27257

  7. Sybille Peters abandoned the change 05/17/22, 06:27

    See comments