Review main Merged

74648[BUGFIX] Stop mocking classes that do not exist

Oliver Klee CR +2 V +2 Easy +5 −29 updated 05/16/22, 16:03

Commit message

This is only possible with PHPUnit, not with Prophecy, and it is bad
practice as there is no way to do type analysis on classes that do
not exist.

Also avoid using mocks where an `stdClass` instance does just fine.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 812

  1. Oliver Klee uploaded patch set 1 05/15/22, 12:18

  2. Oliver Klee updated the commit message in patch set 2 05/15/22, 12:19

  3. Oliver Klee updated the commit message in patch set 3 05/15/22, 12:20

  4. core-ci voted on patch set 2 V +1 05/15/22, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27226

  5. core-ci voted on patch set 3 V +1 05/15/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27227

  6. core-ci voted on patch set 1 V +1 05/15/22, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27225

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 05/15/22, 12:40

  8. Oliver Klee updated the commit message in patch set 4 05/15/22, 12:47

  9. core-ci voted on patch set 4 V +1 05/15/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27228

  10. Benni Mack voted on patch set 4 V +1 CR +1 05/16/22, 10:55

  11. Stefan Bürk voted on patch set 4 V +2 CR +2 05/16/22, 16:03

  12. Stefan Bürk merged patch set 5 05/16/22, 16:03