Review main Merged

74653[TASK] Resolve PHPStan issues in AbstractRecycleTestCase

crell CR +2 V +2 Easy +2 −18 updated 05/16/22, 23:23

Commit message

Mostly these are due to SimpleXML not casting cleanly to strings,
so making the casts explicit resolves them.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. crell uploaded patch set 1 05/16/22, 19:58

  2. crell updated the commit message in patch set 2 05/16/22, 19:59

  3. core-ci voted on patch set 2 V +1 05/16/22, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27263

  4. Oliver Klee commented on patch set 2 05/16/22, 20:08

    Can we backport this to 11.5?
  5. core-ci voted on patch set 1 V +1 05/16/22, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27262

  6. crell commented on patch set 2 05/16/22, 20:28

    Reply

    It should be safe to, yes.
  7. crell updated the commit message in patch set 3 05/16/22, 20:28

  8. core-ci voted on patch set 3 V +1 05/16/22, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27265

  9. Oliver Klee voted on patch set 3 V +1 CR +1 05/16/22, 21:04

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 05/16/22, 23:23

  11. Stefan Bürk merged patch set 4 05/16/22, 23:23