Review main Merged

74676[TASK] Note nullable parameters and returns as such

crell CR +2 V +2 Normal +5 −50 updated 05/31/22, 07:35

Commit message

Based on the code, these parameters are nullable. The doc
comments should reflect that. Doing so eliminates several
PHPStan warnings.

Whether these parameters ought to be nullable is a question
for another time.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2534

Show 69 earlier messages
  1. crell uploaded patch set 1 05/17/22, 20:07

  2. crell uploaded patch set 2 05/17/22, 20:09

  3. core-ci voted on patch set 1 V +1 05/17/22, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27289

  4. core-ci voted on patch set 2 V +1 05/17/22, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27290

  5. Oliver Klee voted on patch set 2 CR +1 05/17/22, 21:58

  6. Oliver Klee wrote 05/18/22, 19:41

    Removed reviewer Oliver Klee with the following votes: * Code-Review+1 by Oliver Klee
  7. crell uploaded patch set 3 05/23/22, 17:00

  8. core-ci voted on patch set 3 V +1 05/23/22, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27410

  9. Oliver Klee commented on patch set 3 05/23/22, 17:37

    phpstan-baseline.neon:4514

    This change adds white space in the baseline file. I recommend regenerating the baseline. (Manually editing it is never a. good idea.)
  1. Stefan Bürk uploaded patch set 4 05/23/22, 20:37

  2. Stefan Bürk commented on patch set 4 05/23/22, 20:38

    phpstan-baseline.neon:4514 Reply

    Done
  3. core-ci voted on patch set 4 V +1 05/23/22, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27414

  4. Oliver Klee wrote 05/23/22, 22:06

    Removed cc Oliver Klee.
  5. Oliver Klee commented on patch set 5 05/24/22, 08:26

    Published edit on patch set 4.
  6. core-ci voted on patch set 5 V +1 05/24/22, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27424

  7. crell voted on patch set 5 CR +1 05/25/22, 16:19

  8. crell uploaded patch set 6 05/27/22, 15:32

  9. core-ci voted on patch set 6 V +1 05/27/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27500

  10. Simon Schaufelberger voted on patch set 6 V +1 CR +1 05/29/22, 16:14

  11. Nikita Hovratov uploaded patch set 7 05/30/22, 13:59

  12. Oliver Klee commented on patch set 7 05/30/22, 14:02

    ClosureFinisher.php:59

    In PHPDoc, nullable types should use the |null notation, not the ? notation: \Closure|null
  13. core-ci voted on patch set 7 V -1 05/30/22, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27585

  14. Oliver Klee commented on patch set 7 05/30/22, 14:33

    ClosureFinisher.php:59 Reply

    Done
  15. Oliver Klee uploaded patch set 8 05/30/22, 14:34

  16. Oliver Klee commented on patch set 8 05/30/22, 14:38

    SetupModuleController.php:745

    Why should it be string? Shouldn't we adapt the callers instead and add casts? Anyway, this change seems out of scope for "Note nullable parameters and returns" and should go into a separate changeset.
  17. core-ci voted on patch set 8 V +1 05/30/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27586

  18. Oliver Klee commented on patch set 8 05/30/22, 14:46

    SetupModuleController.php:745 Reply

    Fixed instead (correctly) by this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74351
  19. Oliver Klee uploaded patch set 9 05/30/22, 14:46

  20. core-ci voted on patch set 9 V +1 05/30/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27587

  21. Oliver Klee voted on patch set 9 V +1 05/30/22, 14:55

  22. Simon Schaufelberger voted on patch set 9 V +1 CR +1 05/30/22, 15:10

  23. Nikita Hovratov voted on patch set 9 V +1 CR +1 05/30/22, 16:17

  24. Stefan Bürk voted on patch set 9 V +2 CR +2 05/31/22, 07:35

  25. Stefan Bürk merged patch set 10 05/31/22, 07:35