74676[TASK] Note nullable parameters and returns as such
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan/phpstan-baseline.neon2+0 −45
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMap.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/ClosureFinisher.php2+1 −1
Review log 2534
Show 69 earlier messages
-
crell uploaded patch set 1 05/17/22, 20:07
-
crell uploaded patch set 2 05/17/22, 20:09
-
core-ci voted on patch set 1 V +1 05/17/22, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27289
-
core-ci voted on patch set 2 V +1 05/17/22, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27290
-
Oliver Klee voted on patch set 2 CR +1 05/17/22, 21:58
-
Oliver Klee wrote 05/18/22, 19:41
Removed reviewer Oliver Klee with the following votes: * Code-Review+1 by Oliver Klee -
crell uploaded patch set 3 05/23/22, 17:00
-
core-ci voted on patch set 3 V +1 05/23/22, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27410
-
Oliver Klee commented on patch set 3 05/23/22, 17:37
phpstan-baseline.neon:4514This change adds white space in the baseline file. I recommend regenerating the baseline. (Manually editing it is never a. good idea.)
-
Stefan Bürk uploaded patch set 4 05/23/22, 20:37
-
Stefan Bürk commented on patch set 4 05/23/22, 20:38
phpstan-baseline.neon:4514ReplyDone -
core-ci voted on patch set 4 V +1 05/23/22, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27414
-
Oliver Klee wrote 05/23/22, 22:06
Removed cc Oliver Klee. -
Oliver Klee commented on patch set 5 05/24/22, 08:26
Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 05/24/22, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27424
-
crell voted on patch set 5 CR +1 05/25/22, 16:19
-
crell uploaded patch set 6 05/27/22, 15:32
-
core-ci voted on patch set 6 V +1 05/27/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27500
-
Simon Schaufelberger voted on patch set 6 V +1 CR +1 05/29/22, 16:14
-
Nikita Hovratov uploaded patch set 7 05/30/22, 13:59
-
Oliver Klee commented on patch set 7 05/30/22, 14:02
ClosureFinisher.php:59In PHPDoc, nullable types should use the |null notation, not the ? notation: \Closure|null -
core-ci voted on patch set 7 V -1 05/30/22, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27585
-
Oliver Klee commented on patch set 7 05/30/22, 14:33
ClosureFinisher.php:59ReplyDone -
Oliver Klee uploaded patch set 8 05/30/22, 14:34
-
Oliver Klee commented on patch set 8 05/30/22, 14:38
SetupModuleController.php:745Why should it be string? Shouldn't we adapt the callers instead and add casts? Anyway, this change seems out of scope for "Note nullable parameters and returns" and should go into a separate changeset. -
core-ci voted on patch set 8 V +1 05/30/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27586
-
Oliver Klee commented on patch set 8 05/30/22, 14:46
SetupModuleController.php:745ReplyFixed instead (correctly) by this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74351 -
Oliver Klee uploaded patch set 9 05/30/22, 14:46
-
core-ci voted on patch set 9 V +1 05/30/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27587
-
Oliver Klee voted on patch set 9 V +1 05/30/22, 14:55
-
Simon Schaufelberger voted on patch set 9 V +1 CR +1 05/30/22, 15:10
-
Nikita Hovratov voted on patch set 9 V +1 CR +1 05/30/22, 16:17
-
Stefan Bürk voted on patch set 9 V +2 CR +2 05/31/22, 07:35
-
Stefan Bürk merged patch set 10 05/31/22, 07:35