Review main Merged

74678[BUGFIX] Avoid undefined array key warnings in GifBuilder

Simon Schaufelberger CR +2 V +2 Easy +2 −2 updated 05/25/22, 10:37

Commit message

GIFBUILDER processing doesn't return a processedFile

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Markus Klein +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1619

  1. Simon Schaufelberger uploaded patch set 1 05/18/22, 11:01

  2. core-ci voted on patch set 1 V -1 05/18/22, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27296

  3. Oliver Klee voted on patch set 1 CR +1 05/18/22, 11:15

  4. core-ci voted on patch set 1 V +1 05/18/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27296

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 05/18/22, 23:15

  6. Markus Klein commented on patch set 1 05/24/22, 10:52

    GifBuilder.php:191

    same here?
  7. Simon Schaufelberger commented on patch set 1 05/24/22, 11:40

    GifBuilder.php:191 Reply

    There is no test case which covers this code block afaik. That's why nobody stumbled over it yet. Do you know how to enter this part? It seems like a very unlikely path.
  8. Markus Klein commented on patch set 1 05/24/22, 11:59

    GifBuilder.php:191 Reply

    IMO this is the wrong way of approaching this. The question rather must be: Can we guarantee $fileInfo has this key? If not, we need to cover that case. (no matter how this is reachable or not, edge case, etc)
  9. Oliver Klee commented on patch set 1 05/24/22, 12:05

    GifBuilder.php:191 Reply

    +1
  10. Simon Schaufelberger commented on patch set 1 05/24/22, 12:32

    GifBuilder.php:191 Reply

    the methode "getResource" always returns an origFile or a processedFile except if you do some magic in the hook "getImgResourcePostProcess" at the end. I've tried to even use a "fileadmin/webp" but even in this case I get an "origFile" and then the code block is not entered, so the only way to enter this code block is through the hook as it seams. I'm just trying to find the edge case here.
  11. Simon Schaufelberger uploaded patch set 2 05/24/22, 13:43

  12. Oliver Klee voted on patch set 2 CR +1 05/24/22, 13:46

  13. core-ci voted on patch set 2 V +1 05/24/22, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27433

  14. Markus Klein voted on patch set 2 V +1 CR +1 05/24/22, 14:34

  15. Oliver Hader voted on patch set 2 CR +1 05/24/22, 16:41

  16. Christian Kuhn voted on patch set 2 V +1 CR +1 05/25/22, 07:59

  17. Oli Bartsch voted on patch set 2 V +2 CR +2 05/25/22, 10:36

  18. Oli Bartsch merged patch set 3 05/25/22, 10:37

  19. Oli Bartsch commented on patch set 3 05/25/22, 10:37

    GifBuilder.php:191 Reply

    Done