74679[FEATURE] Add option to influence display of the website title
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
- Tobias D. +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Riccardo De Contardi +1
- Tobias D. +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97653-TypoScriptOptionShowWebsiteTitle.rstnew+30 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+11 −11
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/TitleTagRenderingTest.typoscript+4 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+54 −0
- typo3/sysext/t3editor/Resources/Private/tsref.xml+5 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js+1 −0
Review log 1619
-
Tobias D. uploaded patch set 1 05/18/22, 12:54
-
core-ci voted on patch set 1 V +1 05/18/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27299
-
Oliver Klee commented on patch set 1 05/18/22, 13:10
Please let's cover the new behavior with a test. -
Mathias Brodala commented on patch set 1 CR -1 05/18/22, 13:12
Feature-97653-NoWebsiteTitleTypoScriptOption.rst:22If at all this should be "websiteTitle" / "showWebsiteTitle" / "renderWebsiteTitle", then 1 by default and 0 to disable. It's a bad habit in the TYPO3 world to enable an option to disable something. We don't need to stick to this legacy. -
Oliver Klee commented on patch set 1 CR -1 05/18/22, 13:17
TypoScriptFrontendController.php:1978And if we're adding new parameters, we need to add them at the end to keep this change non-breaking. -
Tobias D. commented on patch set 1 05/18/22, 13:38
Feature-97653-NoWebsiteTitleTypoScriptOption.rst:22ReplyI agree, it just felt better to use like this at first since config.noPageTitle is already an option and this way it's identical. I can reverse the logic, but would you recommend to reverse the logic of config.noPageTitle as well while already at it (that would be breaking though)? -
Oliver Klee commented on patch set 1 05/18/22, 13:40
Feature-97653-NoWebsiteTitleTypoScriptOption.rst:22ReplyPlease let's do those two things in separate changeset (even though they indeed are related): "Only one change per changeset" -
Mathias Brodala commented on patch set 1 05/18/22, 13:41
Feature-97653-NoWebsiteTitleTypoScriptOption.rst:22ReplyAck -
Tobias D. uploaded patch set 2 05/18/22, 13:59
-
Tobias D. commented on patch set 2 05/18/22, 14:03
Feature-97653-NoWebsiteTitleTypoScriptOption.rst:22ReplyThe logic for this option is reversed now.TypoScriptFrontendController.php:1978ReplyI moved the new parameter to the end. -
core-ci voted on patch set 2 V +1 05/18/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27300
-
Oli Bartsch uploaded patch set 3 05/20/22, 22:38
-
core-ci voted on patch set 3 V +1 05/20/22, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27361
-
Oli Bartsch commented on patch set 3 V +1 CR +1 05/20/22, 22:49
Reply
Added.TypoScriptFrontendController.php:1978ReplyDone -
Riccardo De Contardi voted on patch set 3 V +1 05/21/22, 09:50
-
Oliver Klee voted on patch set 3 CR +1 05/21/22, 12:09
-
Tobias D. voted on patch set 3 V +1 CR +1 05/23/22, 08:10
-
Stefan Bürk voted on patch set 3 V +2 CR +2 05/23/22, 14:55
-
Stefan Bürk merged patch set 4 05/23/22, 14:56