Review 11.5 Abandoned

74682[TASK] Use local TypoScriptFrontendController in COs

Markus Friedrich CR 0 V 0 Normal +74 −107 updated 07/08/22, 15:56

Commit message

Adapts several content object to use the local
TypoScriptFrontendController of ContentObjectRenderer, to reduce
usage of global objects and to avoid conflicts if different frontend
environments are used, e.g. while indexing with EXT:solr.

This adaption should be save as the ContentObjectRenderer falls
back on the global TypoScriptFrontendController which was used in
the content objects until now.

Affected content objects:
- TextMenuContentObject
- ContentContentObject
- ContentObjectArrayInternalContentObject
- EditPanelContentObject
- FilesContentObject
- HierarchicalMenuContentObject
- ImageContentObject
- ImageResourceContentObject
- LoadRegisterContentObject
- RecordsContentObject
- RestoreRegisterContentObject
- UserInternalContentObject

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 14

Review log 56

  1. Markus Friedrich uploaded patch set 1 05/18/22, 14:28

  2. Mathias Brodala commented on patch set 1 05/18/22, 14:37

    You should wait with backports until changes have been merged into "main". Otherwise you'll constantly need to backport updates.
  3. core-ci voted on patch set 1 V -1 05/18/22, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27303

  4. Simon Schaufelberger commented on patch set 1 07/08/22, 15:33

    Unresolved

    Why are there 2 patches with the same target branch? https://review.typo3.org/c/Packages/TYPO3.CMS/+/75073
  5. Nikita Hovratov commented on patch set 1 07/08/22, 15:56

    There was no backport intended for this patch. Besides, only core-merger should backport patches.
  6. Nikita Hovratov abandoned the change 07/08/22, 15:56

    No backport for this patch.