Review main Merged

74691[BUGFIX] Properly handle shortcuts for creating new records

Oli Bartsch CR +2 V +2 Normal +74 −20 updated 05/25/22, 11:21

Commit message

When creating bookmarks to the "new" view in FormEngine,
those bookmark previously did not show up in the toolbar list,
because the parent page access check failed.

This is now fixed by also resolving the parent page for
new record bookmarks properly.

Additionally the shortcut title for those use cases does
now match the title, displayed in FormEngine.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Oli Bartsch uploaded patch set 1 05/20/22, 12:15

  2. core-ci voted on patch set 1 V +1 05/20/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27352

  3. Oliver Klee commented on patch set 1 05/20/22, 13:08

    Is there any way we can add a regression test for this fix?
  4. Oli Bartsch uploaded patch set 2 05/20/22, 13:44

  5. Oli Bartsch commented on patch set 2 05/20/22, 13:44

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 05/20/22, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27353

  7. Jochen Roth voted on patch set 2 V +1 CR +1 05/24/22, 08:39

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 05/25/22, 11:20

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 05/25/22, 11:21

  10. Oli Bartsch merged patch set 3 05/25/22, 11:21