Review 11.5 Merged

74697[BUGFIX] Use plugin icon in content element preview

Benni Mack CR +2 V +2 Normal +69 −2 updated 05/20/22, 08:30

Commit message

It is possible to register a dedicated icon for a plugin in
ExtensionUtility::registerPlugin(). This icon is used in the
plugin select field, but not for the content element preview
where always a default icon is shown.

With this change, a possible configured plugin icon is used
in content element preview, if the icon is registered using
the TYPO3 icon API.

Additionally the indexed_search plugin now uses
'mimetypes-x-content-form-search' as plugin icon.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 05/20/22, 06:47

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/indexed_search/Configuration/TCA/Overrides/tt_content.php
  2. Benni Mack commented on patch set 2 05/20/22, 06:47

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 05/20/22, 06:47

  4. core-ci voted on patch set 1 V -1 05/20/22, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27340

  5. core-ci voted on patch set 2 V +1 05/20/22, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27341

  6. Benni Mack voted on patch set 2 V +2 CR +2 05/20/22, 08:30

  7. Benni Mack merged patch set 3 05/20/22, 08:30