Review main Merged

74717[TASK] Extend 'runTests.sh' to clean rendered documentation

Stefan Bürk CR +2 V +2 Easy +12 −0 updated 06/11/22, 12:28

Commit message

This change adds the ability to clean rendered documentation
folder and files in all system extension folders in one go.
Mentioned folders are `typo3/sysext/*/Documentation-GENERATED-temp`.

Added command/testsuite:

* `Build/Scripts/runTests.sh -s cleanRenderedDocumentation`

Additionally the already combined cleaning command `-s clean`
is extended to delete rendered documentation in the same run.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Stefan Bürk uploaded patch set 1 05/22/22, 12:29

  2. core-ci voted on patch set 1 V +1 05/22/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27390

  3. Simon Schaufelberger voted on patch set 1 CR +1 05/22/22, 23:10

  4. Christian Kuhn commented on patch set 1 05/23/22, 20:36

    Clean rendered documentation files ... rm: cannot remove '../../../typo3/sysext/*/Documentation-GENERATED-temp': No such file or directory could we suppress this error output?
  5. Stefan Bürk uploaded patch set 2 05/23/22, 21:06

  6. Stefan Bürk commented on patch set 2 05/23/22, 21:06

    Reply

    my bad ... removed "-f" instead of "-v" before pushing it. done.
  7. core-ci voted on patch set 2 V +1 05/23/22, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27416

  8. Stefan Bürk rebased onto patch set 3 05/28/22, 22:32

  9. core-ci voted on patch set 3 V -1 05/28/22, 22:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27533

  10. core-ci voted on patch set 3 V +1 05/28/22, 23:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27533

  11. Simon Schaufelberger voted on patch set 3 CR +1 05/28/22, 23:23

  12. Stefan Bürk rebased onto patch set 4 06/11/22, 12:14

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 06/11/22, 12:23

  14. core-ci voted on patch set 4 V +1 06/11/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27974

  15. Stefan Bürk voted on patch set 4 V +2 CR +2 06/11/22, 12:27

  16. Stefan Bürk commented on patch set 4 06/11/22, 12:27

    Merging as no brainer and test related.
  17. Stefan Bürk merged patch set 5 06/11/22, 12:28