Review main Merged

74721[TASK] Update the testing framework

Oliver Klee CR +2 V +2 Normal +94 −4 updated 05/23/22, 13:45

Commit message

This update also reveals some instances where our type
annotations in the tests are not specific enough.
This will be tackled in a separate change.

Used commands:

> composer update typo3/testing-framework
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Oliver Klee uploaded patch set 1 05/23/22, 12:03

  2. Simon Schaufelberger voted on patch set 1 V +1 CR +1 05/23/22, 12:06

  3. core-ci voted on patch set 1 V +1 05/23/22, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27398

  4. core-ci commented on patch set 1 05/23/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27400

  5. Stefan Bürk updated the commit message in patch set 2 05/23/22, 13:11

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/23/22, 13:13

  7. core-ci voted on patch set 2 V +1 05/23/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27401

  8. Stefan Bürk commented on patch set 2 05/23/22, 13:21

    Nightly was green/happy. However backport not possible.
  9. Oliver Klee commented on patch set 2 05/23/22, 13:22

    Reply

    Ack
  10. Stefan Bürk commented on patch set 2 V +2 CR +2 05/23/22, 13:42

    Reply

    We need for TF 6.x a new tag, and a dedicated patch for v11 only which raises to the new tag version instead. (6.14.5 etc)
  11. Stefan Bürk merged patch set 3 05/23/22, 13:42

  12. Simon Schaufelberger commented on patch set 3 05/23/22, 13:45

    Reply

    Dropping an old TYPO3 version should increase the major version digit. That makes updating dependencies much easier.