Review main Merged

74722[TASK] Update PHPStan to version 1.7.0

Oliver Klee CR +2 V +2 Easy +16 −26 updated 05/23/22, 15:52

Commit message

The new version finds some new possible bugs and
removes some incorrect ones.

Used commands:

> composer req --dev phpstan/phpstan:^1.7.0
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Oliver Klee uploaded patch set 1 05/23/22, 15:31

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 05/23/22, 15:37

  3. Stefan Bürk updated the commit message in patch set 2 05/23/22, 15:39

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 05/23/22, 15:40

  5. core-ci voted on patch set 1 V +1 05/23/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27403

  6. core-ci voted on patch set 2 V +1 05/23/22, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27404

  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 05/23/22, 15:50

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 05/23/22, 15:52

  9. Stefan Bürk merged patch set 3 05/23/22, 15:52