Review main Merged

7473[TASK] Scheduler: Add "Add Task" button to header

Markus Klein CR +2 V +2 Easy +16 −11 updated 06/03/13, 20:49

Commit message

This patch adds a "Add Task" button to the left area of
the module header.
It improves usability for long task lists and enforces
the standard layout of backend modules.
The "Add Task" link below the table is removed at the
same time.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 2

Review log 16

  1. Andreas Wolf merged patch set 1 12/24/11, 12:52

  2. Markus Klein commented on patch set 1 12/24/11, 12:52

    Oh yes sorry. The empty condition is the problem here. New patch comes.
  3. Markus Klein uploaded patch set 2 12/24/11, 12:52

  4. Andreas Wolf uploaded patch set 4 12/24/11, 12:52

  5. Andreas Wolf commented on patch set 4 V 0 12/24/11, 12:52

    by team member; Looks good to me, approved Fixed a really tiny whitespace issue. Apart from that, patch looks good and has enough votes, so submitting it.
  6. Tolleiv Nietsch commented on patch set 3 12/24/11, 12:52

    Verified; Looks good to me, but someone else must approve
  7. Markus Klein commented on patch set 3 12/24/11, 12:52

    Okay, I didn't dare to do it. ;-)
  8. Philipp Gampe uploaded patch set 3 12/24/11, 12:52

  9. Philipp Gampe commented on patch set 3 12/24/11, 12:52

    Verified; Looks good to me, but someone else must approve I just removed the add task link.
  10. Felix Kopp commented on patch set 1 12/24/11, 12:52

    Fails The Button also appears on functions "Setup check" and "Information" - but clicking while not on "Schedules tasks" fails
  11. Felix Kopp commented on patch set 2 V 0 12/24/11, 12:52

    I think we should remove the "Add task" link below. That does not make sense any longer and the style with underline on the nbsp is somehow distracting.
  12. Felix Kopp commented on patch set 3 12/24/11, 12:52

    Verified; Looks good to me, but someone else must approve 'Add Task' could be added to information function menu as well. But I like it a lot! Tested against master.
  13. Mr. Jenkins commented on patch set 1 12/24/11, 12:52

  14. Mr. Jenkins commented on patch set 2 12/24/11, 12:52

  15. Mr. Jenkins commented on patch set 3 12/24/11, 12:52

  16. Mr. Jenkins commented on patch set 4 12/24/11, 12:52