7473[TASK] Scheduler: Add "Add Task" button to header
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
-
Verified V +2
- Andreas Wolf +2
Issues 1
Files 2
Review log 16
-
Andreas Wolf merged patch set 1 12/24/11, 12:52
-
Markus Klein commented on patch set 1 12/24/11, 12:52
Oh yes sorry. The empty condition is the problem here. New patch comes. -
Markus Klein uploaded patch set 2 12/24/11, 12:52
-
Andreas Wolf uploaded patch set 4 12/24/11, 12:52
-
Andreas Wolf commented on patch set 4 V 0 12/24/11, 12:52
by team member; Looks good to me, approved Fixed a really tiny whitespace issue. Apart from that, patch looks good and has enough votes, so submitting it. -
Tolleiv Nietsch commented on patch set 3 12/24/11, 12:52
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 3 12/24/11, 12:52
Okay, I didn't dare to do it. ;-) -
Philipp Gampe uploaded patch set 3 12/24/11, 12:52
-
Philipp Gampe commented on patch set 3 12/24/11, 12:52
Verified; Looks good to me, but someone else must approve I just removed the add task link. -
Felix Kopp commented on patch set 1 12/24/11, 12:52
Fails The Button also appears on functions "Setup check" and "Information" - but clicking while not on "Schedules tasks" fails -
Felix Kopp commented on patch set 2 V 0 12/24/11, 12:52
I think we should remove the "Add task" link below. That does not make sense any longer and the style with underline on the nbsp is somehow distracting. -
Felix Kopp commented on patch set 3 12/24/11, 12:52
Verified; Looks good to me, but someone else must approve 'Add Task' could be added to information function menu as well. But I like it a lot! Tested against master. -
Mr. Jenkins commented on patch set 1 12/24/11, 12:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2851/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/24/11, 12:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2852/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/24/11, 12:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2857/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/24/11, 12:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2872/ : SUCCESS