Review main Merged

74738[TASK] Align the test field annotations with the testing framework

Oliver Klee CR +2 V +2 Hard +12 −528 updated 05/25/22, 11:59

Commit message

Also drop type annotations that already are present in the
corresponding field in the superclass, and drop some type annotations
that are redundant with the existing native type declarations.

This helps resolves a bunch of new PHPStan warnings after the recent
changes in the testing framework. It also helps static code analysis,
and makes the code more succinct.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 159

Show 139 more files

Review log 89

  1. Oliver Klee uploaded patch set 1 05/24/22, 16:37

  2. Oliver Klee commented on patch set 1 05/24/22, 16:37

    How to test: - check that the unit and functional tests are still green - check that PHPStan has nothing to complain about
  3. core-ci voted on patch set 1 V +1 05/24/22, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27436

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 05/25/22, 07:58

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 05/25/22, 11:21

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 05/25/22, 11:22

  7. Christian Kuhn merged patch set 2 05/25/22, 11:22

  8. Christian Kuhn commented on patch set 2 05/25/22, 11:58

    Note: No backport to v11 since that is *way* to much hassle with 160 conflicting files.
  9. Oliver Klee commented on patch set 2 05/25/22, 11:59

    Reply

    Ack. Thanks for trying!