74738[TASK] Align the test field annotations with the testing framework
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 159
- Build/phpstan/phpstan-baseline.neon+1 −46
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/SiteConfigurationOverridesTest.php+0 −6
- typo3/sysext/backend/Tests/Functional/Routing/RouterTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/EditRecordViewHelperTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/NewRecordViewHelperTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Mfa/IfHasStateViewHelperTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Uri/EditRecordViewHelperTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Uri/NewRecordViewHelperTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFolderTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+0 −3
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+0 −4
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+0 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/MemcachedBackendTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php+0 −3
Show 139 more files
- typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Cache/Core/ClassAliasLoaderTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Cache/Frontend/VariableFrontendTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Command/CacheFlushCommandTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Html/DefaultSanitizerBuilderTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Imaging/ImageMagickFileTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Mail/FluidEmailTest.php+0 −6
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+0 −3
- typo3/sysext/core/Tests/Functional/RateLimiter/RateLimiterFactoryTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Resource/Security/SvgSanitizerTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Service/Archive/ZipServiceTest.php+0 −3
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+0 −3
- typo3/sysext/core/Tests/Functional/TypoScript/Parser/TypoScriptParserTest.php+0 −3
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconForRecordViewHelperTest.php+0 −3
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Authentication/AuthenticationServiceTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/SqlReaderTest.php+0 −3
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −3
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Localization/TcaSystemLanguageCollectorTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Mail/MailMessageTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+0 −3
- typo3/sysext/core/Tests/Unit/MetaTag/MetaTagManagerRegistryTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+0 −6
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/RelativeCssPathFixerTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Service/FlexFormServiceTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −6
- typo3/sysext/core/Tests/Unit/Utility/MailUtilityTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityTest.php+0 −4
- typo3/sysext/dashboard/Tests/Unit/DashboardPresetRegistryTest.php+0 −3
- typo3/sysext/dashboard/Tests/Unit/WidgetGroupRegistryTest.php+0 −3
- typo3/sysext/dashboard/Tests/Unit/WidgetRegistryTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ArrayConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/BooleanConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/DateTimeConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/FloatConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/IntegerConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectStorageConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/StringConverterTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+0 −3
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+1 −5
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php+1 −3
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/CssViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/Security/IfHasRoleViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/UriViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/Select/OptionViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/ButtonViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/HiddenViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/PasswordViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SubmitViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/BytesViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CaseViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CropViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CurrencyViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/DateViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlentitiesDecodeViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlentitiesViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/Nl2brViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/NumberViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/PaddingViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/StripTagsViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/UrlencodeViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ExternalViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Sanitize/HtmlViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Security/IfAuthenticatedViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Security/IfHasRoleViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ExternalViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ResourceViewHelperTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingStandaloneTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingTest.php+0 −3
- typo3/sysext/fluid/Tests/FunctionalDeprecated/ViewHelpers/Be/Labels/CshViewHelperTest.php+0 −3
- typo3/sysext/form/Tests/Functional/ViewHelpers/UploadedResourceViewHelperTest.php+0 −3
- typo3/sysext/form/Tests/Unit/Controller/FormEditorControllerTest.php+0 −3
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+1 −3
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+0 −4
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+1 −0
- typo3/sysext/form/Tests/Unit/Domain/Renderable/RenderableVariantTest.php+0 −3
- typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntimeTest.php+1 −3
- typo3/sysext/form/Tests/Unit/Hooks/DataStructureIdentifierHookTest.php+1 −3
- typo3/sysext/form/Tests/Unit/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+1 −3
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+0 −3
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Controller/ErrorControllerTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteBaseRedirectResolverTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+1 −6
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithRteImagesAndFileLinkTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+0 −4
- typo3/sysext/impexp/Tests/Unit/ExportTest.php+0 −3
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+0 −3
- typo3/sysext/install/Tests/Functional/Controller/BackendModuleControllerTest.php+0 −3
- typo3/sysext/install/Tests/Functional/Service/Typo3tempFileServiceTest.php+0 −3
- typo3/sysext/install/Tests/Functional/Service/WebServerConfigurationFileServiceTest.php+0 −3
- typo3/sysext/install/Tests/Functional/ViewHelpers/Format/PhpErrorCodeViewHelperTest.php+0 −3
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+0 −3
- typo3/sysext/install/Tests/Unit/Service/EnableFileServiceTest.php+0 −3
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+1 −3
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+0 −3
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+0 −3
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.php+0 −2
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+0 −3
Review log 89
-
Oliver Klee uploaded patch set 1 05/24/22, 16:37
-
Oliver Klee commented on patch set 1 05/24/22, 16:37
How to test: - check that the unit and functional tests are still green - check that PHPStan has nothing to complain about -
core-ci voted on patch set 1 V +1 05/24/22, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27436
-
Christian Kuhn voted on patch set 1 V +1 CR +1 05/25/22, 07:58
-
Oli Bartsch voted on patch set 1 V +1 CR +1 05/25/22, 11:21
-
Christian Kuhn voted on patch set 1 V +2 CR +2 05/25/22, 11:22
-
Christian Kuhn merged patch set 2 05/25/22, 11:22
-
Christian Kuhn commented on patch set 2 05/25/22, 11:58
Note: No backport to v11 since that is *way* to much hassle with 160 conflicting files. -
Oliver Klee commented on patch set 2 05/25/22, 11:59
Reply
Ack. Thanks for trying!