Review 11.5 Merged

74740[TASK] Simplify code in ConjunctionValidator

Christian Kuhn CR +2 V +2 Easy +4 −19 updated 05/25/22, 11:22

Commit message

The code in ConjunctionValidator can be greatly
simplified by taking advantage of the fact that
an empty result object can be merged with a future
one. That eliminates an unnecessary code path as
well as phpstan warnings.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 05/25/22, 11:13

  2. Oliver Klee voted on patch set 1 CR +1 05/25/22, 11:17

  3. core-ci voted on patch set 1 V +1 05/25/22, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27447

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 05/25/22, 11:22

  5. Christian Kuhn merged patch set 2 05/25/22, 11:22