74742[BUGFIX] Prevent exception caused by hash collisions in indexed_search
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 4
Files 5
- typo3/sysext/indexed_search/Classes/Indexer.php6+28 −2
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/indexing_words_twice_first.csvnew+10 −0
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/indexing_words_twice_second.csvnew+10 −0
- typo3/sysext/indexed_search/Tests/Functional/Fixtures/Indexer/phash_collision.csvnew+13 −0
- typo3/sysext/indexed_search/Tests/Functional/IndexerTest.php+91 −0
Review log 3444
Show 1519 earlier messages
-
Florian Schöppe uploaded patch set 1 05/25/22, 12:23
-
core-ci voted on patch set 1 V +1 05/25/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27452
-
Jonas Eberle commented on patch set 1 V +1 05/25/22, 14:10
Thank you! It's easily reproducible with the wordlist from #84541. I've tested in a v10 and v11 and also watched out for performance regressions.Indexer.php:2046@param and @return PHP doc could be string[] -
Jonas Eberle commented on patch set 1 05/25/22, 14:16
Additional note for testers: The error is only reproducible if EXTENSIONS/indexed_search/useMysqlFulltext is set. -
Jonas Eberle commented on patch set 1 05/25/22, 14:18
Reply
> Additional note for testers: The error is only reproducible if EXTENSIONS/indexed_search/useMysqlFulltext is set. Correction. If it is *not* set of course. -
Florian Schöppe uploaded patch set 2 05/25/22, 17:08
-
Florian Schöppe commented on patch set 2 05/25/22, 17:10
Indexer.php:2046ReplyDone -
core-ci voted on patch set 2 V -1 05/25/22, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27460
-
Florian Schöppe uploaded patch set 3 05/25/22, 17:36
-
Florian Schöppe commented on patch set 3 05/25/22, 17:39
Indexer.php:2046ReplyJust reverted that change: The variable name $wordList suggests the array is an array of strings but in fact both, the argument and the returned array, have a more complex structure. -
core-ci voted on patch set 3 V +1 05/25/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27462
-
Jonas Eberle commented on patch set 3 05/25/22, 17:47
Sorry, my bad! That not just a string[]. -
Jonas Eberle voted on patch set 3 V +1 05/25/22, 17:47
-
crell commented on patch set 3 CR +1 05/27/22, 16:21
One style comment, but otherwise seems fine.Indexer.php:1857Why not an array_filter() here, when you use one further down? -
Sybille Peters commented on patch set 3 V +1 05/28/22, 06:00
Tested and verified that exception is not thrown with steps to reproduce from issue: https://forge.typo3.org/issues/84541#Reproduce -
Florian Schöppe commented on patch set 3 06/02/22, 06:26
Indexer.php:1857ReplyYou're right this is inconsistent. I kept the foreach/unset code style when refactoring the old code but introduced the array_filter with the new code. I think it would be best to replace the array_filter with foreach code because array_filter is rarely used throughout indexed_search (and it would be slightly better considering memory and performance). -
Florian Schöppe uploaded patch set 4 06/02/22, 06:40
-
Florian Schöppe commented on patch set 4 06/02/22, 06:44
Indexer.php:1857ReplyDone -
core-ci voted on patch set 4 V +1 06/02/22, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27643
-
Jonas Eberle voted on patch set 4 V +1 CR +1 09/08/22, 11:31
-
Anja Leichsenring commented on patch set 4 11/03/22, 19:16
should we really backport that into v10? I would just say, main and 11.5 is enough. -
crell wrote 11/04/22, 00:22
Removed reviewer crell. -
Benni Mack updated the commit message in patch set 5
CR +1V +105/03/23, 09:25 -
core-ci voted on patch set 5 V -1 05/03/23, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41409
-
Sybille Peters wrote 05/03/23, 12:21
Removed reviewer Sybille Peters. -
Jonas Eberle rebased onto patch set 6
V -106/27/23, 15:50 -
Jonas Eberle commented on patch set 6 V +1 06/27/23, 15:50
Just rebased. -
core-ci voted on patch set 6 V -1 06/27/23, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43042
-
Jonas Eberle uploaded patch set 7
V +106/29/23, 09:18 -
core-ci voted on patch set 7 V +1 06/29/23, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43104
-
Jonas Eberle voted on patch set 7 V +1 CR +1 06/29/23, 09:27
-
Benni Mack updated the commit message in patch set 8
CR +1V +106/30/23, 09:49 -
Benni Mack commented on patch set 8 06/30/23, 09:49
We need a new issue which this patch actually resolves -
core-ci voted on patch set 8 V +1 06/30/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43144
-
Benni Mack voted on patch set 8 V +1 CR +1 07/04/23, 20:06
-
Benni Mack commented on patch set 8 CR -1 07/05/23, 11:49
we still need a ticket -
Stefan Bürk uploaded patch set 9
CR -1V +107/05/23, 15:47 -
core-ci voted on patch set 9 V -1 07/05/23, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43550
-
Stefan Bürk rebased onto patch set 10
V -107/05/23, 16:35 -
core-ci voted on patch set 10 V +1 07/05/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43559
-
Stefan Bürk voted on patch set 10 V +1 CR +1 07/05/23, 17:04
-
Benni Mack voted on patch set 10 V +1 CR +1 07/05/23, 17:06
-
Stefan Bürk voted on patch set 10 V +2 CR +2 07/05/23, 17:18
-
Stefan Bürk merged patch set 11 07/05/23, 17:18