Review main Merged

74745[BUGFIX] Make schedulable commands field identifiers unique

Oli Bartsch CR +2 V +2 Normal +96 −5 updated 05/31/22, 10:11

Commit message

The scheduler module contains a special task,
which allows to select schedulable symfony
commands.

The corresponding field provider therefore
adds the commands' configured arguments
and options. Due to insufficient prefixing, it
was not possible to display arguments and
options with the same name. Additionally,
using "action" as name always overwrote
the "select schedulable commands" field.

This is now resolved by adding proper prefixes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Torben Hansen +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Oli Bartsch uploaded patch set 1 05/25/22, 21:00

  2. core-ci voted on patch set 1 V +1 05/25/22, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27468

  3. crell commented on patch set 1 CR +1 05/27/22, 15:57

    Code looks OK, but if this is a bugfix is there a reasonable test that can be written to confirm that it does what it says on the tin?
  4. Stefan Bürk voted on patch set 1 V +1 CR +1 05/28/22, 21:31

  5. Torben Hansen voted on patch set 1 CR +1 05/29/22, 11:35

  6. Oli Bartsch uploaded patch set 2 05/30/22, 10:38

  7. Oli Bartsch uploaded patch set 3 05/30/22, 10:45

  8. core-ci voted on patch set 2 V +1 05/30/22, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27581

  9. core-ci voted on patch set 3 V +1 05/30/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27582

  10. Oli Bartsch commented on patch set 3 05/30/22, 11:02

    Reply

    Done
  11. Stefan Bürk voted on patch set 3 V +1 CR +1 05/31/22, 07:31

  12. Torben Hansen voted on patch set 3 V +1 CR +1 05/31/22, 08:47

  13. Jochen Roth voted on patch set 3 V +1 CR +1 05/31/22, 09:18

  14. Oli Bartsch voted on patch set 3 V +2 CR +2 05/31/22, 10:11

  15. Oli Bartsch merged patch set 4 05/31/22, 10:11