Review main Merged

74747[BUGFIX] Update guzzlehttp/guzzle to 7.4.3

Andreas Kienast CR +2 V +2 Normal +89 −39 updated 05/27/22, 07:59

Commit message

The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6
respectively, both fixing a security vulnerability related to
cross-domain cookie leakage [1]. Since TYPO3 is not affected by
this issue by default, this is handled as a public bugfix.

However, 3rd party code (e.g. thru extensions) may be affected by this
issue, as long `'cookies' => true` is used in requests done by Guzzle.

Executed commands:

    composer require \
        guzzlehttp/guzzle:^7.4.3 \
        -W
    composer require \
        -d typo3/sysext/core \
        guzzlehttp/guzzle:^7.4.3 \
        --no-update

[1] https://github.com/guzzle/guzzle/security/advisories/GHSA-cwmx-hcrq-mhc3

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Andreas Kienast uploaded patch set 1 05/26/22, 13:04

  2. Andreas Kienast commented on patch set 1 05/26/22, 13:05

    Note: when backporting this patch to 10.5, guzzlehttp/guzzle must be updated to 6.5.6 instead.
  3. core-ci voted on patch set 1 V +1 05/26/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27476

  4. Stefan Bürk updated the commit message in patch set 2 05/26/22, 14:02

  5. Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/26/22, 14:03

  6. core-ci voted on patch set 2 V +1 05/26/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27477

  7. Oliver Klee voted on patch set 2 V +1 CR +1 05/26/22, 14:10

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 05/26/22, 14:28

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 05/27/22, 07:59

  10. Andreas Kienast merged patch set 3 05/27/22, 07:59