74749[TASK] Align the test field annotations with the testing framework
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- crell +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 8
- Build/phpstan/phpstan-baseline.neon+0 −30
- typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/SiteConfigurationOverridesTest.php+0 −3
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+0 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithRteImagesAndFileLinkTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+0 −2
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.php+0 −2
Review log 1112
-
Oliver Klee uploaded patch set 1 05/26/22, 17:26
-
core-ci voted on patch set 1 V +1 05/26/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27481
-
crell voted on patch set 1 CR +1 05/27/22, 15:55
-
Stefan Bürk commented on patch set 1 05/28/22, 21:31
This only a percentile of the original patch, as manual backport after core-merger backport declined. Can we handle this as a new patch with new forge issue only for v11 and doing it only "related" to the orignal main patch ? -
Oliver Klee commented on patch set 1 05/28/22, 22:26
Reply
I'm fine either way. Making it a new patch with a separate issue would require blocklisting #97687 for backporting (which is why Lolli asked me to do the backport if possible). @Lolli, what's your preference? -
Stefan Bürk commented on patch set 1 05/28/22, 22:29
Reply
If lolli asked for it it, it would be okay for me. Not read this in the main patch. Lets wait for his opinion on this, as he merged the main patch. -
Christian Kuhn commented on patch set 1 05/29/22, 02:25
fine with me to make this a partial-backport of original issue with same change-id as proposed by oliver with current patch version. -
Simon Schaufelberger voted on patch set 1 V +1 CR +1 05/29/22, 14:37
-
Oliver Klee commented on patch set 1 05/29/22, 14:47
Reply
Done -
Oliver Klee commented on patch set 1 05/29/22, 14:48
Reply
Done -
Stefan Bürk voted on patch set 1 V +2 CR +2 06/03/22, 15:37
-
Stefan Bürk merged patch set 2 06/03/22, 15:37