Review 11.5 Merged

74749[TASK] Align the test field annotations with the testing framework

Oliver Klee CR +2 V +2 Easy +0 −49 updated 06/03/22, 15:37

Commit message

Also drop type annotations that already are present in the
corresponding field in the superclass, and drop some type annotations
that are redundant with the existing native type declarations.

This helps resolves a bunch of new PHPStan warnings after the recent
changes in the testing framework. It also helps static code analysis,
and makes the code more succinct.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • crell +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1112

  1. Oliver Klee uploaded patch set 1 05/26/22, 17:26

  2. core-ci voted on patch set 1 V +1 05/26/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27481

  3. crell voted on patch set 1 CR +1 05/27/22, 15:55

  4. Stefan Bürk commented on patch set 1 05/28/22, 21:31

    This only a percentile of the original patch, as manual backport after core-merger backport declined. Can we handle this as a new patch with new forge issue only for v11 and doing it only "related" to the orignal main patch ?
  5. Oliver Klee commented on patch set 1 05/28/22, 22:26

    Reply

    I'm fine either way. Making it a new patch with a separate issue would require blocklisting #97687 for backporting (which is why Lolli asked me to do the backport if possible). @Lolli, what's your preference?
  6. Stefan Bürk commented on patch set 1 05/28/22, 22:29

    Reply

    If lolli asked for it it, it would be okay for me. Not read this in the main patch. Lets wait for his opinion on this, as he merged the main patch.
  7. Christian Kuhn commented on patch set 1 05/29/22, 02:25

    fine with me to make this a partial-backport of original issue with same change-id as proposed by oliver with current patch version.
  8. Simon Schaufelberger voted on patch set 1 V +1 CR +1 05/29/22, 14:37

  9. Oliver Klee commented on patch set 1 05/29/22, 14:47

    Reply

    Done
  10. Oliver Klee commented on patch set 1 05/29/22, 14:48

    Reply

    Done
  11. Stefan Bürk voted on patch set 1 V +2 CR +2 06/03/22, 15:37

  12. Stefan Bürk merged patch set 2 06/03/22, 15:37