Review 11.5 Merged

74771[TASK] Solve several phpstan issues in GifBuilder

Stefan Bürk CR +2 V +2 Normal +139 −14 updated 06/06/22, 20:10

Commit message

Also add some (indirect) basic tests for
GifBuilder::calculateValue.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Stefan Bürk commented on patch set 1 06/06/22, 19:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 06/06/22, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27747

  3. Stefan Bürk uploaded patch set 2 06/06/22, 20:02

  4. Oliver Klee voted on patch set 2 CR +1 06/06/22, 20:06

  5. core-ci voted on patch set 2 V +1 06/06/22, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27748

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 06/06/22, 20:10

  7. Stefan Bürk merged patch set 3 06/06/22, 20:10