Review main Merged

74773[TASK] Add `function_to_constant` to php-cs-fixer

Andreas Kienast CR +2 V +2 Easy +3 −2 updated 05/27/22, 11:26

Commit message

php-cs-fixer has the fixer `function_to_constant` which replaces PHP
functions to their equivalent constants, which is added with this
commit.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Andreas Kienast uploaded patch set 1 05/27/22, 08:27

  2. core-ci voted on patch set 1 V -1 05/27/22, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27488

  3. core-ci voted on patch set 1 V +1 05/27/22, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27488

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 05/27/22, 08:51

  5. Oliver Klee voted on patch set 1 V +1 CR +1 05/27/22, 09:40

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 05/27/22, 11:26

  7. Andreas Kienast merged patch set 2 05/27/22, 11:26