Review main Merged Breaking

74777[!!!][TASK] Remove TSconfig options related to new content wizard

Simon Schaufelberger CR +2 V +2 Hard +100 −177 updated 07/07/22, 15:18

Commit message

The TSconfig options "mod.web_layout.disableNewContentElementWizard"
and "mod.newContentElementWizard.override" are removed
with this patch as they are serving edge-case usages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 3

Files 12

Review log 2843

Show 1018 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 05/27/22, 19:46

  2. Simon Schaufelberger commented on patch set 1 05/27/22, 19:48

    I have implemented the deprecation you requested but since I'm not familiar with deprecations, would you help me please with the rest file?
  3. core-ci voted on patch set 1 V +1 05/27/22, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27504

  4. Simon Schaufelberger uploaded patch set 2 05/27/22, 19:55

  5. core-ci voted on patch set 2 V +1 05/27/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27505

  6. Stefan Bürk commented on patch set 2 05/28/22, 21:27

    I would say beside the deprecation ReST file text, following should be done: * add the deprecated property to the corresponding Extension Scanner configuration, see: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php * properly deprecate the public property using the `\TYPO3\CMS\Core\Compatibility\PublicPropertyDeprecationTrait`, see also: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/HowToDeprecateThings.html#make-class-properties-protected * after adding the ExtensionScanner entry, use the correct scanned flaged in the ReST file (FullyScanned if all deprecated things are covered, PartiallyScanned if only partly etc.) See: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/ExtensionScanner/Index.html#connection-to-the-changelog-restructuredtext-files Not into that topic, the deprecation ReST file should at least state why this that property is deprecated, what "will" happen in v12 and what some has to do to migrate, if there is a migration available (if not removed). If removed, make that clear and maybe state the reason for it.
  7. Rachel Foucard voted on patch set 2 V +1 05/29/22, 14:38

  8. Simon Schaufelberger uploaded patch set 3 05/29/22, 23:22

  9. Simon Schaufelberger uploaded patch set 4 05/29/22, 23:25

  10. Simon Schaufelberger uploaded patch set 5 05/29/22, 23:27

  11. core-ci voted on patch set 3 V -1 05/29/22, 23:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27567

  12. core-ci voted on patch set 5 V +1 05/29/22, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27569

  13. core-ci voted on patch set 4 V +1 05/29/22, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27568

  14. Simon Schaufelberger uploaded patch set 6 05/29/22, 23:35

  15. core-ci voted on patch set 6 V -1 05/29/22, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27570

  16. core-ci voted on patch set 6 V +1 05/30/22, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27570

  17. Simon Schaufelberger rebased onto patch set 7 06/07/22, 01:49

  18. core-ci voted on patch set 7 V +1 06/07/22, 01:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27759

  1. Benni Mack commented on patch set 7 06/10/22, 15:07

  2. Simon Schaufelberger commented on patch set 7 CR -1 06/10/22, 17:29

    Reply

    I will do so and define it as breaking instead.
  3. Simon Schaufelberger uploaded patch set 8 06/13/22, 21:10

  4. Simon Schaufelberger commented on patch set 8 06/13/22, 21:15

    Reply

    Done
  5. Simon Schaufelberger updated the commit message in patch set 9 06/13/22, 21:16

  6. core-ci voted on patch set 8 V +1 06/13/22, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28028

  7. core-ci voted on patch set 9 V +1 06/13/22, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28029

  8. Benni Mack commented on patch set 9 07/04/22, 15:05

    would be good if the commit message actually contains much more information.

    Breaking-97701-RemoveShowNewContentWizard.rst:33

    This RST reads a bit odd. * Description: Explain the option and what it was used for, and where it could be set. E.g. in this case that a new content element is always created of type= text and the CType needed to be set afterwards * Impact: Explain what happens after this change ("This option has no effect anymore and TYPO3 behaves as if the option is never set") * Affected installations: Explain how integrators / developers can find out if they have the option disabled * Migration: "Remove the option as it does not have any effect anymore. Instead, use TSconfig to configure the new content element to your needs"
  9. Simon Schaufelberger uploaded patch set 10 07/05/22, 00:04

  10. Simon Schaufelberger commented on patch set 9 07/05/22, 00:05

    Breaking-97701-RemoveShowNewContentWizard.rst:33 Reply

    Writing RST files is not my strength, but I hope it's better now.
  11. core-ci voted on patch set 10 V -1 07/05/22, 00:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28644

  12. Benni Mack uploaded patch set 11 07/07/22, 14:42

  13. core-ci voted on patch set 11 V +1 07/07/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28713

  14. Benni Mack voted on patch set 11 V +1 CR +1 07/07/22, 14:49

  15. Simon Schaufelberger updated the commit message in patch set 12 07/07/22, 14:50

  16. Benni Mack commented on patch set 12 CR -1 07/07/22, 14:51

    on it
  17. Benni Mack uploaded patch set 13 07/07/22, 14:52

  18. Simon Schaufelberger commented on patch set 13 07/07/22, 14:54

    Good catch! thank you Benni!
  19. core-ci voted on patch set 12 V +1 07/07/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28714

  20. core-ci voted on patch set 13 V -1 07/07/22, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28715

  21. core-ci voted on patch set 13 V +1 07/07/22, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28715

  22. Benni Mack voted on patch set 13 V +1 CR +1 07/07/22, 15:08

  23. Oli Bartsch voted on patch set 13 V +1 CR +1 07/07/22, 15:18

  24. Benni Mack voted on patch set 13 V +2 CR +2 07/07/22, 15:18

  25. Benni Mack merged patch set 14 07/07/22, 15:18