74778[TASK] Improve and clean up some type annotations in tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+1 −16
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+0 −5
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −4
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+3 −0
- typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php+0 −5
Review log 79
-
Oliver Klee uploaded patch set 1 05/28/22, 09:12
-
core-ci voted on patch set 1 V +1 05/28/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27509
-
Oliver Klee updated the commit message in patch set 2 05/28/22, 09:24
-
Oliver Klee commented on patch set 2 05/28/22, 09:29
How to test: 1. Check that PHPStan does not complain. 2. Check that the tests are green. -
core-ci voted on patch set 2 V +1 05/28/22, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27510
-
Stefan Bürk voted on patch set 2 V +1 CR +1 05/28/22, 21:09
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/29/22, 00:14
-
Stefan Bürk voted on patch set 2 V +2 CR +2 05/29/22, 11:33
-
Stefan Bürk merged patch set 3 05/29/22, 11:33