Review main Merged

74778[TASK] Improve and clean up some type annotations in tests

Oliver Klee CR +2 V +2 Easy +5 −30 updated 05/29/22, 11:33

Commit message

This gets rids of some PHPStan warnings triggered by the latest
testing framework raise.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Oliver Klee uploaded patch set 1 05/28/22, 09:12

  2. core-ci voted on patch set 1 V +1 05/28/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27509

  3. Oliver Klee updated the commit message in patch set 2 05/28/22, 09:24

  4. Oliver Klee commented on patch set 2 05/28/22, 09:29

    How to test: 1. Check that PHPStan does not complain. 2. Check that the tests are green.
  5. core-ci voted on patch set 2 V +1 05/28/22, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27510

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 05/28/22, 21:09

  7. Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/29/22, 00:14

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 05/29/22, 11:33

  9. Stefan Bürk merged patch set 3 05/29/22, 11:33