Review main Merged

74779[TASK] Make the return type of GeneralUtility::tempnam more specific

Oliver Klee CR +2 V +2 Easy +8 −25 updated 05/30/22, 05:10

Commit message

Also adapt the callers accordingly. This resolves a few PHPStan warnings
and allows simplifying some code.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 911

  1. Oliver Klee uploaded patch set 1 05/28/22, 09:28

  2. core-ci voted on patch set 1 V +1 05/28/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27511

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 05/28/22, 21:13

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 05/29/22, 00:14

  5. Oliver Klee uploaded patch set 2 05/29/22, 11:46

  6. Oliver Klee commented on patch set 2 05/29/22, 11:46

    Rebased.
  7. Stefan Bürk voted on patch set 2 V +1 CR +1 05/29/22, 11:47

  8. core-ci voted on patch set 2 V +1 05/29/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27545

  9. Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/29/22, 14:35

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 05/30/22, 05:10

  11. Stefan Bürk merged patch set 3 05/30/22, 05:10