Review 11.5 Merged

74782[TASK] Remove dead code paths identified by PHPStan

Stefan Bürk CR +2 V +2 Normal +11 −68 updated 05/28/22, 20:52

Commit message

According to PHPStan, these checks are all unnecessary.
Most of them appear to be type checks that have been
rendered unnecessary due later type additions. They
are therefore removed without replacement.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 79

  1. Stefan Bürk uploaded patch set 1 05/28/22, 20:41

  2. Stefan Bürk updated the commit message in patch set 2 05/28/22, 20:41

  3. Stefan Bürk wrote 05/28/22, 20:42

    Removed reviewer Oliver Klee.
  4. Stefan Bürk wrote 05/28/22, 20:42

    Removed reviewer Nikita Hovratov.
  5. Stefan Bürk wrote 05/28/22, 20:42

    Removed reviewer core-ci.
  6. core-ci voted on patch set 1 V +1 05/28/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27527

  7. core-ci voted on patch set 2 V +1 05/28/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27528

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 05/28/22, 20:51

  9. Stefan Bürk merged patch set 3 05/28/22, 20:52